Fragment 1.3.0: onCreateOptionsMenu() not called when showing fragment [180255554]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 15, 2021 06:04PM

Component used: Fragment

Version used:1.3.0

Devices/Android versions reproduced on: Emulator Api level 30

Sample project: https://github.com/libon/BottomNavigationApp

Starting with activity 1.2.0 and fragment 1.3.0: when showing a fragment, it's onCreateOptionsMenu() isn't called.

Two workarounds are possible:

In the activity, call FragmentManager.enableNewStateManager(false)
In the fragment which needs to show an action bar item, call requireActivity().invalidateOptionsMenu() from onHiddenChanged(hidden: Boolean)

Comments

il...@google.com <il...@google.com> Feb 16, 2021 05:54PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Feb 23, 2021 05:41AM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

jb...@google.com <jb...@google.com> #3Feb 25, 2021 10:43PM

Marked as fixed.

This has been fixed internally and will be released as part of the Fragment 1.3.1 version.

You can verify this by following the snapshot instructions with build id 7164304 and switching your fragment dependency to 1.4.0-SNAPSHOT.

Issue 180255554

Description

Issue summary

Comments

il...@google.com <il...@google.com> Feb 16, 2021 05:54PM

ap...@google.com <ap...@google.com> #2Feb 23, 2021 05:41AM

jb...@google.com <jb...@google.com> #3Feb 25, 2021 10:43PM

Add comment

Issue metadata