IssueTracker

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link:      https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

#2, yeah, that's the same issue.

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.8.0-beta01
• androidx.compose.foundation:foundation-android:1.8.0-beta01
• androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
• androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

I cannot share a code snippet now but I've used the same approach exposed in that answer on Stack overflow https://stackoverflow.com/a/46066323/13164665

Thanks for the screenshots.

I think you can do the following as a workaround to draw the pixel art image directly with anti-aliasing disabled:

    val imageBitmap = BitmapFactory.decodeResource(
        LocalContext.current.resources,
        R.drawable.my_pixel_art
    ).asImageBitmap()
    val paint = remember {
        Paint().apply {
            isAntiAlias = false
        }
    }
    Canvas(modifier = Modifier.fillMaxSize()) { // DrawScope
        drawIntoCanvas { canvas ->
            canvas.drawImage(imageBitmap, Offset.Zero, paint)
        }
    }

It's filtering you want to disable for pixel art, not anti-aliasing (although you may want that too when the image is rotated or uses subpixel positioning).

I ended up using a custom Painter. The painter is almost identical to BitmapPainter, I have overwritten only DrawScope.onDraw

private val customPaint = Paint().apply {
    asFrameworkPaint().apply {
        this.isDither = false
        this.isFilterBitmap = false
        this.isAntiAlias = false
    }
}

override fun DrawScope.onDraw() {
    drawIntoCanvas {
        it.drawImageRect(
            image = image,
            srcSize = srcSize,
            srcOffset = srcOffset,
            dstSize = IntSize(
                this@onDraw.size.width.roundToInt(),
                this@onDraw.size.height.roundToInt()
            ),
            paint = customPaint
        )
    }
}