Accessibility support for Lazy* lists: add collectionItemInfo support [180479017]

Fixed

Bug

Status Update

No update yet.

Description

so...@google.com

created issue #1

Feb 17, 2021 11:25AM

We have a selectableGroup modifier for non-lazy lists which iterates through all the 'selectable' nodes to get the indices and number of elements (to set CollectionInfo and CollectionItemInfo). Obviously, this does not play well with lazy lists as it only reports the number of visible elements.

We need to figure out what it the right approach/API for lazy lists.

Comments

yi...@google.com <yi...@google.com> #2Feb 17, 2021 06:00PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

so...@google.com <so...@google.com> #3Feb 17, 2021 07:10PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

cl...@google.com <cl...@google.com> #4Mar 10, 2021 11:29AM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

ma...@google.com <ma...@google.com> #5Apr 12, 2021 05:37PM

deleted

ma...@google.com <ma...@google.com> #6Apr 12, 2021 05:38PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

yi...@google.com <yi...@google.com> #7Apr 12, 2021 06:53PM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

ap...@google.com <ap...@google.com> #8Apr 21, 2021 09:54PM

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

so...@google.com <so...@google.com> Jun 1, 2021 11:52AM

Marked as fixed.