[Compose] Text selection polish (touch & mouse) [180639271]

Obsolete

Feature Request

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 19, 2021 09:30AM

Required features:

~~double/triple click selection~~
drag and drop inside window AND across applications (platform specific)
context menu support
shift-clicks for expanding/shrinking selection

Implementation should be shared between CoreText and CoreTextField

Questions:

did I miss some features?
is double/triple clicks expected behavior the same on all platforms?

Comments

[Deleted User] <[Deleted User]> #2Feb 25, 2021 03:09PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ap...@google.com <ap...@google.com> #3Mar 8, 2021 01:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

si...@google.com <si...@google.com> Apr 8, 2021 12:29AM

Reassigned to Deleted User.

ap...@google.com <ap...@google.com> #4Apr 9, 2021 03:36PM

deleted

si...@google.com <si...@google.com> #5Nov 11, 2021 12:34AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

si...@google.com <si...@google.com> #6Nov 11, 2021 12:35AM

Assigned hardware keyboard/mouse to Matevi for visibility and planning.

si...@google.com <si...@google.com> Nov 16, 2021 05:04PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Nov 18, 2021 10:20AM

Status: New

ma...@google.com <ma...@google.com> #7Nov 18, 2021 06:31PM

Chatted with Siyamed. He is tracking hardware and keyboard as a part of text features.

ae...@google.com <ae...@google.com> Nov 20, 2021 01:46AM

Assigned to si...@google.com.

si...@google.com <si...@google.com> Dec 1, 2021 07:59PM

Reassigned to an...@google.com.

gr...@google.com <gr...@google.com> Jan 17, 2023 11:47PM

Reassigned to gr...@google.com.

ap...@google.com <ap...@google.com> #8Jun 6, 2023 06:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4bd91cd472a563d6a788dd8d1fb1dc0e76b9480f
Author: Grant Toepfer <grantapher@google.com>
Date: Mon Jun 05 11:27:51 2023

Clean up aosp/2470503 bugs

CharacterWithWordAccelerate selection adjustment will temporarily not enforce at least one character selected as it caused multiple unfixable bugs in SelectionContainer.

BTF2 paragraph navigation has the same change applied to it as to BTF1 in aosp/2470503.

SelectionManager consumes the selection gesture even when a selectable is only removed from selection.

Test: ./gradlew :com:found:found:tDUT
Test: ./gradlew :com:found:found:cAT
Test: Manually tested in demo app
Fixes:

Fixes:

Bug:

Bug:

Bug:

Change-Id: I58bbf6c912f0c7701b3b3482d1df37459959b5c2

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/TextFieldSelectionGesturesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/TextSelectionGesturesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/TextFieldKeyEventTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldSelectionTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/TextPreparedSelection.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/MultiWidgetSelectionDelegate.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionAdjustment.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/SelectionManagerTest.kt

https://android-review.googlesource.com/2616177

ap...@google.com <ap...@google.com> #9Jun 6, 2023 06:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit fefbd7ad44bcdf0c0e7353f01744e5a5ef5143c1
Author: Grant Toepfer <grantapher@google.com>
Date: Fri Mar 03 15:02:55 2023

Add support for selection by mouse

Adds automatic delegation of mouse or touch behaviors based on the device sending the pointer event.

Relnote: """Added support for selection by mouse.
Touch based selection will expand by word,
and shrink by character."""
Test: ./gradlew :com:found:found:tDUT
Test: ./gradlew :com:found:found:cAT
Test: Manually tested in demo app
Fixes:

Fixes:

Bug:

Bug:

Bug:

Change-Id: Ic0c6c247aefb9cf567525369468fe19fe77dc986

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextPreparedSelectionTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/modifiers/SelectionControllerTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionDelegateTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/AbstractSelectionGesturesTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/MultiTextSelectionGesturesTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/MultiTextWithSpaceSelectionGesturesRegressionTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/SingleTextSelectionGesturesTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/TextFieldSelectionGesturesTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/TextSelectionGesturesTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/TextSelectionHandlesGesturesTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/util/MultiTextSelectionTestUtils.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/util/SingleTextSelectionTestUtils.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/util/TextFieldSelectionTestUtils.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/gestures/util/TextSelectionTestUtils.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/HardwareKeyboardTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldVisualTransformationCursorTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/TouchMode.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/StringHelpers.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldGestureModifiers.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectionController.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/MultiWidgetSelectionDelegate.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/Selection.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionAdjustment.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionContainer.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionGestures.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionMode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionRegistrar.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionRegistrarImpl.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionDelegate.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextPreparedSelection.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextSelectionMouseDetector.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/SelectionAdjustmentTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/SelectionManagerTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/StringHelpersTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManagerTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/EditProcessor.kt

https://android-review.googlesource.com/2470503

gr...@google.com <gr...@google.com> #10Jun 6, 2023 07:14PM

double and triple click selection added in the above two CLs.

se...@google.com <se...@google.com> #11Oct 25, 2023 10:23PM

Moving to P2 to align with current priority level meanings. Not actually changing priority of ticket.

gr...@google.com <gr...@google.com> #12Jun 28, 2024 11:03PM

Status: Won't Fix (Obsolete)

Splitting remaining tasks from this ticket into others:

Drag and Drop
- b/165682911
Context Menu
- public api: b/332764757
- internal implementation: b/269341173
Shift + left click to update selection
- b/281587544
Double/Triple Tap (Note that click, i.e. mouse click, already has this behavior)
- b/137321832

There also are other minor tasks in the dependencies that aren't reflected with a feature in this bug.

Message last modified on Jul 24, 2024 11:11PM

Issue 180639271

Description

Issue summary

Comments

[Deleted User] <[Deleted User]> #2Feb 25, 2021 03:09PM

ap...@google.com <ap...@google.com> #3Mar 8, 2021 01:26PM

si...@google.com <si...@google.com> Apr 8, 2021 12:29AM

ap...@google.com <ap...@google.com> #4Apr 9, 2021 03:36PM

si...@google.com <si...@google.com> #5Nov 11, 2021 12:34AM

si...@google.com <si...@google.com> #6Nov 11, 2021 12:35AM

si...@google.com <si...@google.com> Nov 16, 2021 05:04PM

ma...@google.com <ma...@google.com> Nov 18, 2021 10:20AM

ma...@google.com <ma...@google.com> #7Nov 18, 2021 06:31PM

ae...@google.com <ae...@google.com> Nov 20, 2021 01:46AM

si...@google.com <si...@google.com> Dec 1, 2021 07:59PM

gr...@google.com <gr...@google.com> Jan 17, 2023 11:47PM

ap...@google.com <ap...@google.com> #8Jun 6, 2023 06:32PM

ap...@google.com <ap...@google.com> #9Jun 6, 2023 06:32PM

gr...@google.com <gr...@google.com> #10Jun 6, 2023 07:14PM

se...@google.com <se...@google.com> #11Oct 25, 2023 10:23PM

gr...@google.com <gr...@google.com> #12Jun 28, 2024 11:03PM

Add comment

Issue metadata