onResume is not called on Fragment 1.3 [180825150]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 22, 2021 12:48PM

Component used: Fragment Version used: 1.3.0 Devices/Android versions reproduced on: Android 10, 11

This is happen on our product code, but, sorry, I could not create sample project to reproduce this issue.

If we update fragment from 1.2.5 to 1.3.0, onResume is not called on one Fragment of our project. This is very similer to https://issuetracker.google.com/issues/177154873

Our Fragment has custom enter/exit transition. If we remove these custom transition, onResume is called as expected. But we can't do that. We need custom transition animation. The difference to above issue (177154873) may that our Fragment is "Fragment on Fragment".

We tried to call FragmentManager.enableNewStateManager(false) written in
https://medium.com/androiddevelopers/fragments-rebuilding-the-internals-61913f8bf48e to disable new state manager.

onResume becomes to be called !! BUT, it cause ConcurrentModificationException.

java.util.HashMap$HashIterator.nextNode (HashMap.java:1441)
java.util.HashMap$KeyIterator.next (HashMap.java:1465)
androidx.fragment.app.FragmentManager.endAnimatingAwayFragments (FragmentManager.java:2489)
androidx.fragment.app.FragmentManager.dispatchDestroy (FragmentManager.java:3090)
androidx.fragment.app.Fragment.performDestroy (Fragment.java:3201)
androidx.fragment.app.FragmentStateManager.destroy (FragmentStateManager.java:771)
androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1449)
androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1509)
androidx.fragment.app.FragmentManager.moveFragmentToExpectedState (FragmentManager.java:1587)
androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1649)
androidx.fragment.app.FragmentManager.executeOpsTogether (FragmentManager.java:2209)
androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute (FragmentManager.java:2094)
androidx.fragment.app.FragmentManager.execPendingActions (FragmentManager.java:1990)
androidx.fragment.app.FragmentManager$5.run (FragmentManager.java:524)
android.os.Handler.handleCallback (Handler.java:938)
android.os.Handler.dispatchMessage (Handler.java:99)
android.os.Looper.loop (Looper.java:223)
android.app.ActivityThread.main (ActivityThread.java:7660)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:592)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:947)

But this is happen on 1.3.0.

Summary:

With new state manager : onResume is not called.
Without new state manager : ConcurrentModificationException is happen

Comments

[Deleted User] <[Deleted User]> #2Feb 22, 2021 02:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

FragmentOnResumeNotCallded.zip

1.3 MB

Download

il...@google.com <il...@google.com> Feb 22, 2021 06:10PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Feb 25, 2021 11:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 081f27aa164ea9566d198f05166130cc27a52bfe
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 24 16:24:59 2021

Complete transitions if the container is not laid out

If the container has not be laid out, beginDelayedTransition() is a
no-op and since the transition is never started, it never ends so the
SpecialEffectController operation never gets completed.

In the case where the container has not been laid out, we should complete
the operation immediately.

Unlike transitions, Animations run whether they have been laided out or
not and they should continue to do so.

RelNote: "Child fragments with transitions will now properly reach
RESUMED"
Test: enterExitChildTransitions
Bug: 180825150

Change-Id: Ic11e655bd4ed206485c2762a1af4e5bc7aa4cf9c

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1607214

jb...@google.com <jb...@google.com> #4Feb 25, 2021 11:36PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.3.1 release.

Issue 180825150

Description

Issue summary

Comments

[Deleted User] <[Deleted User]> #2Feb 22, 2021 02:38PM

il...@google.com <il...@google.com> Feb 22, 2021 06:10PM

ap...@google.com <ap...@google.com> #3Feb 25, 2021 11:26PM

jb...@google.com <jb...@google.com> #4Feb 25, 2021 11:36PM

Add comment

Issue metadata