onResume is not called on Fragment 1.3 [180825150]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 22, 2021 12:48PM

Component used: Fragment Version used: 1.3.0 Devices/Android versions reproduced on: Android 10, 11

This is happen on our product code, but, sorry, I could not create sample project to reproduce this issue.

If we update fragment from 1.2.5 to 1.3.0, onResume is not called on one Fragment of our project. This is very similer to https://issuetracker.google.com/issues/177154873

Our Fragment has custom enter/exit transition. If we remove these custom transition, onResume is called as expected. But we can't do that. We need custom transition animation. The difference to above issue (177154873) may that our Fragment is "Fragment on Fragment".

We tried to call FragmentManager.enableNewStateManager(false) written in
https://medium.com/androiddevelopers/fragments-rebuilding-the-internals-61913f8bf48e to disable new state manager.

onResume becomes to be called !! BUT, it cause ConcurrentModificationException.

java.util.HashMap$HashIterator.nextNode (HashMap.java:1441)
java.util.HashMap$KeyIterator.next (HashMap.java:1465)
androidx.fragment.app.FragmentManager.endAnimatingAwayFragments (FragmentManager.java:2489)
androidx.fragment.app.FragmentManager.dispatchDestroy (FragmentManager.java:3090)
androidx.fragment.app.Fragment.performDestroy (Fragment.java:3201)
androidx.fragment.app.FragmentStateManager.destroy (FragmentStateManager.java:771)
androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1449)
androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1509)
androidx.fragment.app.FragmentManager.moveFragmentToExpectedState (FragmentManager.java:1587)
androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1649)
androidx.fragment.app.FragmentManager.executeOpsTogether (FragmentManager.java:2209)
androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute (FragmentManager.java:2094)
androidx.fragment.app.FragmentManager.execPendingActions (FragmentManager.java:1990)
androidx.fragment.app.FragmentManager$5.run (FragmentManager.java:524)
android.os.Handler.handleCallback (Handler.java:938)
android.os.Handler.dispatchMessage (Handler.java:99)
android.os.Looper.loop (Looper.java:223)
android.app.ActivityThread.main (ActivityThread.java:7660)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:592)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:947)

But this is happen on 1.3.0.

Summary:

With new state manager : onResume is not called.
Without new state manager : ConcurrentModificationException is happen

Comments

[Deleted User] <[Deleted User]> #2Feb 22, 2021 02:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

FragmentOnResumeNotCallded.zip

1.3 MB

Download

il...@google.com <il...@google.com> Feb 22, 2021 06:10PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Feb 25, 2021 11:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 081f27aa164ea9566d198f05166130cc27a52bfe
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 24 16:24:59 2021

Complete transitions if the container is not laid out

If the container has not be laid out, beginDelayedTransition() is a
no-op and since the transition is never started, it never ends so the
SpecialEffectController operation never gets completed.

In the case where the container has not been laid out, we should complete
the operation immediately.

Unlike transitions, Animations run whether they have been laided out or
not and they should continue to do so.

RelNote: "Child fragments with transitions will now properly reach
RESUMED"
Test: enterExitChildTransitions
Bug: 180825150

Change-Id: Ic11e655bd4ed206485c2762a1af4e5bc7aa4cf9c

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1607214

jb...@google.com <jb...@google.com> #4Feb 25, 2021 11:36PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.3.1 release.

Issue 180825150

Description

Issue summary

Comments

[Deleted User] <[Deleted User]> #2Feb 22, 2021 02:38PM

il...@google.com <il...@google.com> Feb 22, 2021 06:10PM

ap...@google.com <ap...@google.com> #3Feb 25, 2021 11:26PM

jb...@google.com <jb...@google.com> #4Feb 25, 2021 11:36PM

Add comment

Issue metadata