WindowInsetsControllerCompat.setAppearanceLightStatusBars not working with windowLightStatusBar=true in API 30 [180881870]

Fixed

Bug

Status Update

No update yet.

Description

gs...@gmail.com

created issue #1

Feb 22, 2021 01:56PM

Component used: androidx.appcompat:appcompat

Version used: 1.3.0-beta01

Devices/Android versions reproduced on: Pixel 5 API 30, Emulator Pixel 4 API 30

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
- Attached
A screenrecord or screenshots showing the issue (if UI related).
- Attached a demo with windowLightStatusBar=false without issues, and a demo with windowLightStatusBar=true showing the issue.

The code in the sample project:


class MainActivity : AppCompatActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        val binding = ActivityMainBinding.inflate(layoutInflater)
        setContentView(binding.root)

        WindowCompat.setDecorFitsSystemWindows(window, false)

        binding.lightButton.setOnClickListener { view ->
            view.requireWindowInsetsController().isAppearanceLightStatusBars = true
        }

        binding.darkButton.setOnClickListener { view ->
            view.requireWindowInsetsController().isAppearanceLightStatusBars = false
        }
    }

    private fun View.requireWindowInsetsController(): WindowInsetsControllerCompat =
        ViewCompat.getWindowInsetsController(this)
            ?: error("Couldn't get WindowInsetsController")

}

StatusBarColorsTest.zip

141 KB

Download

2021-02-22 14-44-19.mp4

873 KB

Download

2021-02-22 14-50-36.mkv

888 KB

Download

Comments

al...@google.com <al...@google.com> Feb 22, 2021 02:47PM

Reassigned to ca...@google.com.

gs...@gmail.com <gs...@gmail.com> #2Feb 22, 2021 03:18PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

gs...@gmail.com <gs...@gmail.com> #3Feb 22, 2021 03:34PM

https://issuetracker.google.com/issues/180250984 looks related to this

[Deleted User] <[Deleted User]> #4Mar 9, 2021 05:22PM

(author of b/180250984 here)

Per the docs of setAppearanceLightStatusBars it seems like this is expected behavior on API 30, and the behavior on API 29 and below is inconsistent with the documentation:

If false, reverts to the default appearance.

So if the theme has windowLightStatusBar=true, then the default behavior is light status bars, meaning there's no way to unset it back to dark status bars. I agree that this is pretty confusing, and also not super helpful.

For a workaround, right now I am just using the old systemUiVisibility flags solution for consistent behavior across API versions, even though it's now deprecated.

ca...@google.com <ca...@google.com> #5Apr 14, 2021 05:10PM

I checked the behavior and what happens is:

API 30: setAppearancLightStatusBars conflicts with SYSTEM_UI_FLAG_LIGHT_STATUS_BAR. The workaround is to unset SYSTEM_UI_FLAG_LIGHT_STATUS_BAR, or set windowLightStatusBar=false. This is a platform bug, a workaround will be implemented in core.
on API < 30: there is indeed a documentation issue that will be fixed, but the behavior is correct.

ca...@google.com <ca...@google.com> #6Apr 14, 2021 05:10PM

Since an easy workaround is possible, this doesn't need to block the release.

[Deleted User] <[Deleted User]> #7Jul 27, 2021 10:13AM

Small addition to #5: It seems like the platform behaviour has changed in Android 12 Beta. So with the WindowInsetsControllerCompat it now seems like:

API > 30: can toggle back and forth
API == 30: cannot toggle|
API < 30: can toggle

Message last modified on Jul 27, 2021 12:04PM

ap...@google.com <ap...@google.com> #8Aug 11, 2021 04:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4b9ea4a8a3e548875e5a5a13f8a7a61ceea58746
Author: Ioana Moraru <ioanamoraru@google.com>
Date: Fri Jul 30 22:17:56 2021

Partially fix setAppearanceLightStatusBars in API 30

WindowInsetsControllerCompat.setAppearanceLightStatusBars not working with windowLightStatusBar=true in API 30. This commit fixes it for the WindowInsetsControllerCompat(window, compatController).

Bug: 180881870
Test: Set windowLightStatusBar=true and trigger setAppearanceLightStatusBar
Test:WindowInsetsControllerCompatActivityTest#systemBar_light_theme

Change-Id: I8961fc92b973ce0357d4d5f0c8919a3b8fe8a460

M core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt
M core/core/src/main/java/androidx/core/view/WindowInsetsControllerCompat.java

https://android-review.googlesource.com/1783607

ca...@google.com <ca...@google.com> Aug 12, 2021 01:47PM

Marked as fixed, reassigned to io...@google.com.

[Deleted User] <[Deleted User]> #9Sep 9, 2021 09:02AM

Which release will include this fix?

ca...@google.com <ca...@google.com> #10Sep 13, 2021 11:13AM

This should be in 1.7.0-beta02.

ap...@google.com <ap...@google.com> #11Feb 1, 2022 11:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit 81f994d8759b8a374d8fb2db1032306c614749dc
Author: Alex Vanyo <vanyo@google.com>
Date: Thu Jan 27 01:28:23 2022

Set system bar appearance flags on API 30 anyway

Issue 180881870

wasn't fully fixed, in the case where the theme had
android:windowLightStatusBar=true and the only interaction was calling
WindowInsetsControllerCompat.isAppearanceLightStatusBars=false

Additionally, the navigation bars scrim wasn't updating properly on API
30, even though the icons were changing.

As an update for both of these, on API 30 we set the corresponding
systemUiVisibility flags anyway, in addition to calling through to the
platform WindowInsetsController.

Fixes: 215832843,180881870
Test: manual + flag test updates

Change-Id: I654496f7701f342eec8fd0e18e4bd353dd4fb2bc

M core/core/src/androidTest/java/androidx/core/view/WindowInsetsControllerCompatActivityTest.kt
M core/core/src/main/java/androidx/core/view/WindowInsetsControllerCompat.java

https://android-review.googlesource.com/1962461

sa...@gmail.com <sa...@gmail.com> #12Mar 13, 2022 03:55PM

Which version includes the fix in #11?

va...@google.com <va...@google.com> #13Mar 14, 2022 04:04PM

The fix in #11 was first released in 1.8.0-alpha04, and will be in future releases as well.

sa...@gmail.com <sa...@gmail.com> #14Mar 28, 2022 12:00PM

There is a crash that is very likely related to `1.8.0-alpha04`
```
Caused by java.lang.NullPointerException: Attempt to read from field 'int android.view.WindowManager$LayoutParams.flags' on a null object reference
at androidx.core.view.WindowInsetsControllerCompat$Impl20.unsetWindowFlag(WindowInsetsControllerCompat.java:511)
at androidx.core.view.WindowInsetsControllerCompat$Impl26.setAppearanceLightNavigationBars(WindowInsetsControllerCompat.java:597)
at androidx.core.view.WindowInsetsControllerCompat.setAppearanceLightNavigationBars(WindowInsetsControllerCompat.java:226)
```
On androids 10,9,8

Might it by any chance be already fixed in `1.8.0-alpha06`?

va...@google.com <va...@google.com> #15Mar 28, 2022 04:12PM

Correct, based on the stacktrace that crash should no longer occur on 1.8.0-alpha06. Have you had a chance to try out 1.8.0-alpha06 and see if it still occurs?

sa...@gmail.com <sa...@gmail.com> #16Mar 29, 2022 04:51PM

Yes it seems to be fixed

va...@google.com <va...@google.com> #17Mar 29, 2022 05:00PM

Glad to hear it!

Issue 180881870

Description

Issue summary

Comments

al...@google.com <al...@google.com> Feb 22, 2021 02:47PM

gs...@gmail.com <gs...@gmail.com> #2Feb 22, 2021 03:18PM

gs...@gmail.com <gs...@gmail.com> #3Feb 22, 2021 03:34PM

[Deleted User] <[Deleted User]> #4Mar 9, 2021 05:22PM

ca...@google.com <ca...@google.com> #5Apr 14, 2021 05:10PM

ca...@google.com <ca...@google.com> #6Apr 14, 2021 05:10PM

[Deleted User] <[Deleted User]> #7Jul 27, 2021 10:13AM

ap...@google.com <ap...@google.com> #8Aug 11, 2021 04:14PM

ca...@google.com <ca...@google.com> Aug 12, 2021 01:47PM

[Deleted User] <[Deleted User]> #9Sep 9, 2021 09:02AM

ca...@google.com <ca...@google.com> #10Sep 13, 2021 11:13AM

ap...@google.com <ap...@google.com> #11Feb 1, 2022 11:07PM

sa...@gmail.com <sa...@gmail.com> #12Mar 13, 2022 03:55PM

va...@google.com <va...@google.com> #13Mar 14, 2022 04:04PM

sa...@gmail.com <sa...@gmail.com> #14Mar 28, 2022 12:00PM

va...@google.com <va...@google.com> #15Mar 28, 2022 04:12PM

sa...@gmail.com <sa...@gmail.com> #16Mar 29, 2022 04:51PM

va...@google.com <va...@google.com> #17Mar 29, 2022 05:00PM

Add comment

Issue metadata