java.lang.IllegalArgumentException when targeting S+ (version 10000 and above) [180884673]

Fixed

Bug

Status Update

No update yet.

Description

en...@gmail.com

created issue #1

Feb 22, 2021 05:29PM

Component used: androidx.work:work-runtime AND androidx.work:work-runtime-ktx Version used: 2.5.0 and 2.7. Devices/Android versions reproduced on: Pixel 4 XL API S (Emulator from Android studio)

Simply adding the dependency of work manager runtime to a sample app (see attached) and targeting API S with

    compileSdkVersion "android-S"
    buildToolsVersion "31.0.0 rc1"

    defaultConfig {
        ...
        targetSdkVersion "S"
        ...
    }

triggers the following runtime error when run on a Pixel 4 emulator with API S

2021-02-22 18:06:21.069 28402-28424/? E/AndroidRuntime: FATAL EXCEPTION: pool-3-thread-1 Process: com.example.myapplication, PID: 28402 java.lang.IllegalArgumentException: com.example.myapplication: Targeting S+ (version 10000 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent. Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles. at android.app.PendingIntent.checkFlags(PendingIntent.java:367) at android.app.PendingIntent.getBroadcastAsUser(PendingIntent.java:640) at android.app.PendingIntent.getBroadcast(PendingIntent.java:626) at androidx.work.impl.utils.ForceStopRunnable.getPendingIntent(ForceStopRunnable.java:273) at androidx.work.impl.utils.ForceStopRunnable.isForceStopped(ForceStopRunnable.java:151) at androidx.work.impl.utils.ForceStopRunnable.forceStopRunnable(ForceStopRunnable.java:171) at androidx.work.impl.utils.ForceStopRunnable.run(ForceStopRunnable.java:102) at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.lang.Thread.run(Thread.java:920)

Same app targeting API 30 works well even on Pixel 4 with API S.

Thank you for your work.

+Enea

MyApplicationCrashWorkManager.zip

20 MB

Download

Comments

ra...@google.com <ra...@google.com> #2Feb 22, 2021 06:01PM

Marked as fixed, reassigned to ra...@google.com.

In SystemJobService, it can expect null, and able to tolerance null from WorkManagerImpl.getInstance, due to auto-backup reason.

@Override
public void onCreate() {
super.onCreate();
mWorkManagerImpl = WorkManagerImpl.getInstance(getApplicationContext());
if (mWorkManagerImpl == null) {
// This can occur if...
// 1. The app is performing an auto-backup. Prior to O, JobScheduler could erroneously
// try to send commands to JobService in this state (

b/32180780

). Since neither
// Application#onCreate nor ContentProviders have run, WorkManager won't be
// initialized. In this case, we should ignore all JobScheduler commands and tell it
// to retry.
But, current WorkManagerImpl.getInstance(Context context) implementation is that, it will never return null but throw IllegalStateException.

Isn't there's conflict among these 2 SystemJobService.onCreate logic, and WorkManagerImpl.getInstance logic?

en...@gmail.com <en...@gmail.com> #3Feb 22, 2021 09:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e14104eb7008f82edd50b37e16bd119b307e0554
Author: Sumir Kataria <sumir@google.com>
Date: Mon Jun 24 10:50:57 2019

Fix for JobScheduler calls when backup is in progress.

The original fix (ag/Ia1604b7c4b98f6b31869e1161a0c1efce7fe46f2) relied
on a null-check, but the new version of WorkManager.getInstance(Context)
with the Context param doesn't return null; it throws an Exception. This
CL updates the three places where we explicitly check for the return value
internally:

1. SystemJobService (the main place where this would manifest)
2. RescheduleReceiver
3. WorkManagerTestInitHelper (for consistency)

Fixes: 135858602
Test: Ran existing tests
Change-Id: Ia232869712d0c78fd80e91d0a863b8c50a080400

M work/workmanager-testing/src/main/java/androidx/work/testing/WorkManagerTestInitHelper.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/RescheduleReceiver.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/988026

https://goto.google.com/android-sha1/e14104eb7008f82edd50b37e16bd119b307e0554

[Deleted User] <[Deleted User]> #4Mar 5, 2021 10:56PM

Thanks you so much for the speedy fixed!

May I know when will it be ready for production? As, currently, this IllegalStateException is impacting our users.

ra...@google.com <ra...@google.com> #5Mar 5, 2021 11:19PM

Hello, please look for this later in the week. If you want to work around this bug specifically and don't need on-demand initialization, you can use the old (deprecated) WorkManager.getInstance() method for now.

to...@gmail.com <to...@gmail.com> Nov 8, 2021 12:49AM

238.jpg

19 KB

View

Download

nd...@gmail.com <nd...@gmail.com> #6Oct 13, 2023 08:18AM

Comment has been deleted.

Message last modified on Nov 3, 2023 11:32AM

nd...@gmail.com <nd...@gmail.com> #7Oct 13, 2023 08:38AM