java.lang.IllegalArgumentException when targeting S+ (version 10000 and above) [180884673]

Fixed

Bug

Status Update

No update yet.

Description

en...@gmail.com

created issue #1

Feb 22, 2021 05:29PM

Component used: androidx.work:work-runtime AND androidx.work:work-runtime-ktx Version used: 2.5.0 and 2.7. Devices/Android versions reproduced on: Pixel 4 XL API S (Emulator from Android studio)

Simply adding the dependency of work manager runtime to a sample app (see attached) and targeting API S with

    compileSdkVersion "android-S"
    buildToolsVersion "31.0.0 rc1"

    defaultConfig {
        ...
        targetSdkVersion "S"
        ...
    }

triggers the following runtime error when run on a Pixel 4 emulator with API S

2021-02-22 18:06:21.069 28402-28424/? E/AndroidRuntime: FATAL EXCEPTION: pool-3-thread-1 Process: com.example.myapplication, PID: 28402 java.lang.IllegalArgumentException: com.example.myapplication: Targeting S+ (version 10000 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent. Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles. at android.app.PendingIntent.checkFlags(PendingIntent.java:367) at android.app.PendingIntent.getBroadcastAsUser(PendingIntent.java:640) at android.app.PendingIntent.getBroadcast(PendingIntent.java:626) at androidx.work.impl.utils.ForceStopRunnable.getPendingIntent(ForceStopRunnable.java:273) at androidx.work.impl.utils.ForceStopRunnable.isForceStopped(ForceStopRunnable.java:151) at androidx.work.impl.utils.ForceStopRunnable.forceStopRunnable(ForceStopRunnable.java:171) at androidx.work.impl.utils.ForceStopRunnable.run(ForceStopRunnable.java:102) at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.lang.Thread.run(Thread.java:920)

Same app targeting API 30 works well even on Pixel 4 with API S.

Thank you for your work.

+Enea

MyApplicationCrashWorkManager.zip

20 MB

Download

Comments

ra...@google.com <ra...@google.com> #2Feb 22, 2021 06:01PM

Marked as fixed, reassigned to ra...@google.com.

Yigit, do you have time to fix it?

reemission of the same liveData is racy

en...@gmail.com <en...@gmail.com> #3Feb 22, 2021 09:33PM

yea i'll take it.

[Deleted User] <[Deleted User]> #4Mar 5, 2021 10:56PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

ra...@google.com <ra...@google.com> #5Mar 5, 2021 11:19PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

to...@gmail.com <to...@gmail.com> Nov 8, 2021 12:49AM

238.jpg

19 KB

View

Download

nd...@gmail.com <nd...@gmail.com> #6Oct 13, 2023 08:18AM

Comment has been deleted.

Message last modified on Nov 3, 2023 11:32AM

nd...@gmail.com <nd...@gmail.com> #7Oct 13, 2023 08:38AM