popExit animation plays instead of exit animation [181142246]

Fixed

Bug

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

Feb 25, 2021 03:24AM

Component used: Fragment

Version used: 1.3.0

Devices/Android versions reproduced on: Pixel 3 XL Android 11

I am observing a case where popExit animation plays instead of exit animation. It happens in the following conditions:

There is only one fragment attached to the activity. (not using navigation components)
Pop this fragment and push a new fragment together.

When I debug the fragment library code, what I see is:

executePopOps(...) -> the OP_ADD case sets nextAnim to popExit -> removeFragment(f) -> setVisibleRemovingFragment(...)
The fragment container sets the current fragment as visible_removing_fragment_view_tag fragment with popExit animation.

Sample project: https://github.com/mkano9/material-container-transform-recycleChildrenOnDetach/tree/popexit-and-exit-reversed

Video attached.

20210224_190258.mp4

432 KB

Download

Comments

il...@google.com <il...@google.com> Feb 26, 2021 08:06PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #2Mar 4, 2021 02:14AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

ap...@google.com <ap...@google.com> #3Mar 13, 2021 01:29AM

Great! Thanks a lot, I'll look for the live updates soon!

jb...@google.com <jb...@google.com> #4Mar 15, 2021 07:18PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.3.2 release.

el...@gmail.com <el...@gmail.com> #5Mar 29, 2021 02:59PM

Hi,

Changes in 1.3.2 seems to create issues when using a navController. In our app we navigate between fragments like this:

findMasterNavController().navigate(Uri.parse(deepLink), NavOptions.Builder().setEnterAnim(R.anim.enter_left)
        .setExitAnim(R.anim.exit_right)
        .setPopEnterAnim(R.anim.enter_right)
        .setPopExitAnim(R.anim.exit_left)
        .build())

Then when pressing the back button, the exit anim isn't played.

Cheers,

il...@google.com <il...@google.com> #6Mar 29, 2021 03:11PM

Re #5 - please file a new bug with a sample project that reproduces your issue.

pr...@gmail.com <pr...@gmail.com> #7Mar 30, 2021 06:19AM

Re #6 I am also facing same issue exit animations does not work even if i set it from navigation graph and using Direction Classes

el...@gmail.com <el...@gmail.com> #8Mar 30, 2021 08:38AM

#6, seems someone already did it: https://issuetracker.google.com/issues/183877426

jo...@gmail.com <jo...@gmail.com> #9Apr 8, 2021 09:40PM

Same issue here with navController not playing the exit animations properly any longer.