Crash when disconnecting from headunit when navigation is started [181143772]

Fixed

Bug

Status Update

No update yet.

Description

kr...@tomtom.com

created issue #1

Feb 25, 2021 11:23AM

Library version used: 1.0.0-beta01

Devices/Android versions reproduced on: Any

Android Auto version reproduced on: 6.1.6105

Crash when disconnecting from headunit when navigation is started. Simply start the app, start navigating, disconnect/close dhu. After Android Auto service gets destroyed - this is where we clear NavigationManager callback, this crash occurs.

    java.lang.NullPointerException
        at java.util.Objects.requireNonNull(Objects.java:220)
        at androidx.car.app.navigation.NavigationManager.lambda$onStopNavigation$3$NavigationManager(NavigationManager.java:285)
        at androidx.car.app.navigation.-$$Lambda$NavigationManager$VfCV3KNUFOmGR8cBjFUUBVJugqQ.run(Unknown Source:2)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:246)
        at android.app.ActivityThread.main(ActivityThread.java:8456)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:596)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

It seems that NavigationManager tries to call onStopNavigation in the callback even though the service is no longer created.

Comments

kr...@tomtom.com <kr...@tomtom.com> #2Mar 1, 2021 12:49PM

Fixed in aosp/2133650.

li...@tomtom.com <li...@tomtom.com> #3Mar 8, 2021 11:02AM

Project: platform/frameworks/support
Branch: androidx-main

commit 47782e507ed18b73c1453949544bb7075edfe6dd
Author: Alan Viverette <alanv@google.com>
Date: Tue Jun 21 16:27:55 2022

Clean up lint issues in arch core

Does not fix nullability for methods inheriting from JUnit TestWatcher,
which is not annotated.

Relnote: Updated nullability
Fixes: 236472329
Fixes: 236472101
Fixes: 236472102
Fixes: 236471987
Fixes: 236472078
Fixes: 236472176
Fixes: 236471905
Fixes: 236472103
Test: arch core test suite
Change-Id: I34b6b636572f1bce61d38af563b4a989aa108f82

M arch/core/core-testing/api/restricted_current.txt
M arch/core/core-runtime/api/restricted_current.txt
M arch/core/core-runtime/src/main/java/androidx/arch/core/executor/ArchTaskExecutor.java
M arch/core/core-common/src/main/java/androidx/arch/core/internal/SafeIterableMap.java
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/testing/CountingTaskExecutorRule.java
M arch/core/core-testing/api/public_plus_experimental_current.txt
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/JunitTaskExecutorRule.java
M arch/core/core-common/api/restricted_current.txt
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/testing/InstantTaskExecutorRule.java
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/TaskExecutorWithFakeMainThread.java
M arch/core/core-testing/api/current.txt
M arch/core/core-common/src/main/java/androidx/arch/core/internal/FastSafeIterableMap.java
M arch/core/core-runtime/src/main/java/androidx/arch/core/executor/DefaultTaskExecutor.java

https://android-review.googlesource.com/2133650

li...@google.com <li...@google.com> Mar 9, 2021 05:00PM

Assigned to li...@google.com.

li...@google.com <li...@google.com> #4Mar 9, 2021 09:05PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.arch.core:core-common:2.2.0-alpha01
androidx.arch.core:core-runtime:2.2.0-alpha01
androidx.arch.core:core-testing:2.2.0-alpha01

li...@google.com <li...@google.com> Mar 10, 2021 12:37AM

Accepted by li...@google.com.

li...@google.com <li...@google.com> #5Mar 10, 2021 06:50PM

Marked as fixed.

Pkbk pyare bk janu I am miss you babu bk janu I am miss you babu bk janu 🌻🌺 you are not 🚭 I love you janu 🌿🌻 you are free I love u so much mam for you janu 🌻🏵️ you are not 🚫🚭🚫 you are

ap...@google.com <ap...@google.com> #6Mar 10, 2021 06:51PM

Lawde

kr...@tomtom.com <kr...@tomtom.com> #7Mar 11, 2021 08:55AM

As per comment in https://android-review.googlesource.com/c/platform/frameworks/support/+/1624421/4#message-5aefce71146b7665bc24aaa2bc5ca2d7dc0f6b83

The deferred nature of this callback may still cause issues to car library clients like us.

li...@google.com <li...@google.com> Mar 17, 2021 08:41PM

Status: Assigned (reopened)

li...@google.com <li...@google.com> #8Mar 17, 2021 09:44PM

Thanks for pointing this out, working on a fix now

ap...@google.com <ap...@google.com> #9Mar 17, 2021 11:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit 19a4e804b650056de0ecb54a2470e98fcb076727
Author: Rafael Lima <therafael@google.com>
Date: Wed Mar 17 21:46:05 2021

Do not callback `NavigationManagerCallback#onStopNavigation` if the callback is cleared before the executor executes

Relnote: Do not callback `NavigationManagerCallback#onStopNavigation` if the callback is cleared before the executor executes
Bug: 181143772
Test: Unit tests
Change-Id: I7fc5ebe1f371b0530f084f76236ab058f71f2a5c

M car/app/app/src/main/java/androidx/car/app/navigation/NavigationManager.java
M car/app/app/src/test/java/androidx/car/app/navigation/NavigationManagerTest.java

https://android-review.googlesource.com/1643642

li...@google.com <li...@google.com> Mar 22, 2021 05:09PM

Marked as fixed.

kr...@tomtom.com <kr...@tomtom.com> #10Mar 25, 2021 09:18AM

Thanks a lot for fixing it! Is there any ETA for new library release?

sh...@google.com <sh...@google.com> #11Mar 25, 2021 05:58PM

This should be part of the now-released rc01 https://developer.android.com/jetpack/androidx/releases/car-app#1.0.0-rc01