ANR with paging 3 & room if the db is busy with queries when the LimitOffsetDataSource is created [181221318]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

ev...@tatarka.me

created issue #1

Feb 25, 2021 04:25PM

Component used: room, paging v3 Version used: 3.0.0-beta01, 2.3.0-beta02

If the db is busy with quires (in our case a lot of inserts in a transaction), and the paging method on the room Dao is called, we get an ANR in the LimitOffsetDataSource constructor as it's waiting on the db.

        at android.database.sqlite.SQLiteConnectionPool.waitForConnection(SQLiteConnectionPool.java:670)
        at android.database.sqlite.SQLiteConnectionPool.acquireConnection(SQLiteConnectionPool.java:348)
        at android.database.sqlite.SQLiteSession.acquireConnection(SQLiteSession.java:894)
        at android.database.sqlite.SQLiteSession.beginTransactionUnchecked(SQLiteSession.java:310)
        at android.database.sqlite.SQLiteSession.beginTransaction(SQLiteSession.java:298)
        at android.database.sqlite.SQLiteDatabase.beginTransaction(SQLiteDatabase.java:505)
        at android.database.sqlite.SQLiteDatabase.beginTransactionNonExclusive(SQLiteDatabase.java:440)
        at androidx.sqlite.db.framework.FrameworkSQLiteDatabase.beginTransactionNonExclusive(FrameworkSQLiteDatabase.java:74)
        at androidx.room.InvalidationTracker.beginTransactionInternal(InvalidationTracker.java:342)
        at androidx.room.InvalidationTracker.syncTriggers(InvalidationTracker.java:556)
        at androidx.room.InvalidationTracker.syncTriggers(InvalidationTracker.java:596)
        at androidx.room.InvalidationTracker.addObserver(InvalidationTracker.java:306)
        at androidx.room.InvalidationTracker.addWeakObserver(InvalidationTracker.java:360)
        at androidx.room.paging.LimitOffsetDataSource.<init>(LimitOffsetDataSource.java:74)
        at androidx.room.paging.LimitOffsetDataSource.<init>(LimitOffsetDataSource.java:58)

Comments

du...@google.com <du...@google.com> #2Feb 25, 2021 04:52PM

For Kotlin 2.0 and KSP 2.0 the Cannot change attributes of configuration ':composeApp:debugFrameworkIosX64' after it has been locked for mutation really seems like a KSP issue. You should file a bug in their repository with a sample app if possible.

If you downgrade to Kotlin 1.9 then things 'should' work, there are example apps out there with such configuration, like the following one: https://github.com/realityexpander/KMP_Room/tree/main

yb...@google.com <yb...@google.com> #3Feb 26, 2021 07:26AM

Yes this does seem like a KSP issue however it only starts happening when room is added to the project. As the template project compiles just fine.

Will try to use the example provided by you to check if it fixes the issue.

yb...@google.com <yb...@google.com> Mar 1, 2021 04:44PM

Reassigned to yb...@google.com.

ap...@google.com <ap...@google.com> #4Mar 2, 2021 01:45AM

Note that this issue happens when applying the Compose, KSP and Room Plugin together in Kotlin 2.0.x, the workaround for now is to not use the Room Gradle Plugin and instead specify the schema location vis KSP arguments:

// In the build.gradle
ksp {
    arg("room.schemaLocation", "${projectDir}/schemas")
}

yb...@google.com <yb...@google.com> Mar 2, 2021 01:47AM

Marked as fixed.

Issue 181221318