Fixed
Status Update
Comments
al...@google.com <al...@google.com> #2
Trying to reproduce this on my 4.2.2 (v17) Nexus 4. Added this drawable:
<transition xmlns:android="http://schemas.android.com/apk/res/android " >
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="http://schemas.android.com/apk/res/android "
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
<transition xmlns:android="
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
al...@google.com <al...@google.com> #3
Also not reproducible on Galaxy Nexus running 4.0.1 (v14), 4.0.4 (v15) and 4.2.2 (v17)
al...@google.com <al...@google.com> #4
al...@google.com <al...@google.com> #5
Handling this myself so that we can expedite androidx.core:core:1.3.0-beta03
this batch and then rc01
next batch, thus unblocking appcompat
release candidate.
requesting API change in betab/181797419 - aosp/1615642 upstreaming the patch from
androidx-platform-dev
so...@google.com <so...@google.com> #6
Thanks! We are currently within a code red within gmscore which is unfortunately sucking up all my time, sorry I couldn't get to this immediately!
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 1629a0255116161e889c64b65346314de43b62d1
Author: Soonil Nagarkar <sooniln@google.com>
Date: Fri Oct 09 09:58:08 2020
Hide HandlerExecutor class and expose only static method
Relnote: Added ExecutorCompat, which creates an Executor from a Handler.
Bug: 151655993
Fixes: 181237835
Test: ExecutorCompatTest
Change-Id: Ib4ca32d49f1324c54226ad38988dc21c77a73272
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
A core/core-ktx/api/1.5.0-beta03.txt
A core/core-ktx/api/public_plus_experimental_1.5.0-beta03.txt
A core/core-ktx/api/res-1.5.0-beta03.txt
A core/core-ktx/api/restricted_1.5.0-beta03.txt
A core/core/api/1.5.0-beta03.txt
A core/core/api/current.ignore
M core/core/api/current.txt
A core/core/api/public_plus_experimental_1.5.0-beta03.txt
M core/core/api/public_plus_experimental_current.txt
A core/core/api/res-1.5.0-beta03.txt
A core/core/api/restricted_1.5.0-beta03.txt
A core/core/api/restricted_current.ignore
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/os/ExecutorCompatTest.java
M core/core/src/main/java/androidx/core/location/LocationManagerCompat.java
A core/core/src/main/java/androidx/core/os/ExecutorCompat.java
D core/core/src/main/java/androidx/core/os/HandlerExecutor.java
https://android-review.googlesource.com/1615642
Branch: androidx-main
commit 1629a0255116161e889c64b65346314de43b62d1
Author: Soonil Nagarkar <sooniln@google.com>
Date: Fri Oct 09 09:58:08 2020
Hide HandlerExecutor class and expose only static method
Relnote: Added ExecutorCompat, which creates an Executor from a Handler.
Bug: 151655993
Fixes: 181237835
Test: ExecutorCompatTest
Change-Id: Ib4ca32d49f1324c54226ad38988dc21c77a73272
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
A core/core-ktx/api/1.5.0-beta03.txt
A core/core-ktx/api/public_plus_experimental_1.5.0-beta03.txt
A core/core-ktx/api/res-1.5.0-beta03.txt
A core/core-ktx/api/restricted_1.5.0-beta03.txt
A core/core/api/1.5.0-beta03.txt
A core/core/api/current.ignore
M core/core/api/current.txt
A core/core/api/public_plus_experimental_1.5.0-beta03.txt
M core/core/api/public_plus_experimental_current.txt
A core/core/api/res-1.5.0-beta03.txt
A core/core/api/restricted_1.5.0-beta03.txt
A core/core/api/restricted_current.ignore
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/os/ExecutorCompatTest.java
M core/core/src/main/java/androidx/core/location/LocationManagerCompat.java
A core/core/src/main/java/androidx/core/os/ExecutorCompat.java
D core/core/src/main/java/androidx/core/os/HandlerExecutor.java
Description
HandlerExecutor
was added upstream andandroidx-main
.