HandlerExecutor removed from downstream branch, but still present in core beta [181237835]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Feb 25, 2021 06:14PM

HandlerExecutor was added upstream and removed downstream, leading to a compatibility breakage as the class has launched in a public beta. The class either needs to be restored downstream or removed immediately in androidx-main.

Comments

al...@google.com <al...@google.com> #2Mar 3, 2021 09:16PM

Reassigned to wy...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

al...@google.com <al...@google.com> #3Mar 3, 2021 09:17PM

Thanks for the report!

al...@google.com <al...@google.com> #4Mar 3, 2021 09:18PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

al...@google.com <al...@google.com> #5Mar 3, 2021 09:38PM

Accepted by al...@google.com.

deleted

so...@google.com <so...@google.com> #6Mar 3, 2021 10:04PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

ap...@google.com <ap...@google.com> #7Mar 5, 2021 06:07PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 1629a0255116161e889c64b65346314de43b62d1
Author: Soonil Nagarkar <sooniln@google.com>
Date: Fri Oct 09 09:58:08 2020

Hide HandlerExecutor class and expose only static method

Relnote: Added ExecutorCompat, which creates an Executor from a Handler.
Bug: 151655993
Fixes: 181237835
Test: ExecutorCompatTest
Change-Id: Ib4ca32d49f1324c54226ad38988dc21c77a73272

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
A core/core-ktx/api/1.5.0-beta03.txt
A core/core-ktx/api/public_plus_experimental_1.5.0-beta03.txt
A core/core-ktx/api/res-1.5.0-beta03.txt
A core/core-ktx/api/restricted_1.5.0-beta03.txt
A core/core/api/1.5.0-beta03.txt
A core/core/api/current.ignore
M core/core/api/current.txt
A core/core/api/public_plus_experimental_1.5.0-beta03.txt
M core/core/api/public_plus_experimental_current.txt
A core/core/api/res-1.5.0-beta03.txt
A core/core/api/restricted_1.5.0-beta03.txt
A core/core/api/restricted_current.ignore
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/os/ExecutorCompatTest.java
M core/core/src/main/java/androidx/core/location/LocationManagerCompat.java
A core/core/src/main/java/androidx/core/os/ExecutorCompat.java
D core/core/src/main/java/androidx/core/os/HandlerExecutor.java

https://android-review.googlesource.com/1615642

Issue 181237835