Add default values to PaddingValues(horizontal: Dp, vertical: Dp) [181336792]

Fixed

Bug

Status Update

No update yet.

Description

jm...@gmail.com

created issue #1

Feb 27, 2021 04:59PM

Jetpack Compose release version: 1.0.0-beta01 Android Studio Build:Android Studio Arctic Fox | 2020.3.1 Canary 8 Build #AI-203.7148.57.2031.7165533, built on February 23, 2021

Expected

I want to add vertical content padding to a LazyColumn:

LazyColumn(contentPadding = PaddingValues(vertical = 16.dp)) {}

Actual

The horizontal parameter does not have a default value and therefore the following, more verbose code needs to be written.

LazyColumn(contentPadding = PaddingValues(horizontal = 0.dp, vertical = 16.dp)) {}

The following builder functions are provided for PaddingValues:

fun PaddingValues(all: Dp): PaddingValues = PaddingValuesImpl(all, all, all, all)

fun PaddingValues(horizontal: Dp, vertical: Dp): PaddingValues =
    PaddingValuesImpl(horizontal, vertical, horizontal, vertical)

fun PaddingValues(
    start: Dp = 0.dp,
    top: Dp = 0.dp,
    end: Dp = 0.dp,
    bottom: Dp = 0.dp
): PaddingValues = PaddingValuesImpl(start, top, end, bottom)

Potential solution

Add default values to the existing builder function.

fun PaddingValues(horizontal: Dp = 0.dp, vertical: Dp = 0.dp): PaddingValues =
    PaddingValuesImpl(horizontal, vertical, horizontal, vertical)

The semantics of not passing any parameters, i.e. PaddingValues(), do not change.

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:22PM

Assigned to po...@google.com.

ap...@google.com <ap...@google.com> #2Apr 20, 2021 09:50AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

Issue 181336792