Add default values to PaddingValues(horizontal: Dp, vertical: Dp) [181336792]

Fixed

Bug

Status Update

No update yet.

Description

jm...@gmail.com

created issue #1

Feb 27, 2021 04:59PM

Jetpack Compose release version: 1.0.0-beta01 Android Studio Build:Android Studio Arctic Fox | 2020.3.1 Canary 8 Build #AI-203.7148.57.2031.7165533, built on February 23, 2021

Expected

I want to add vertical content padding to a LazyColumn:

LazyColumn(contentPadding = PaddingValues(vertical = 16.dp)) {}

Actual

The horizontal parameter does not have a default value and therefore the following, more verbose code needs to be written.

LazyColumn(contentPadding = PaddingValues(horizontal = 0.dp, vertical = 16.dp)) {}

The following builder functions are provided for PaddingValues:

fun PaddingValues(all: Dp): PaddingValues = PaddingValuesImpl(all, all, all, all)

fun PaddingValues(horizontal: Dp, vertical: Dp): PaddingValues =
    PaddingValuesImpl(horizontal, vertical, horizontal, vertical)

fun PaddingValues(
    start: Dp = 0.dp,
    top: Dp = 0.dp,
    end: Dp = 0.dp,
    bottom: Dp = 0.dp
): PaddingValues = PaddingValuesImpl(start, top, end, bottom)

Potential solution

Add default values to the existing builder function.

fun PaddingValues(horizontal: Dp = 0.dp, vertical: Dp = 0.dp): PaddingValues =
    PaddingValuesImpl(horizontal, vertical, horizontal, vertical)

The semantics of not passing any parameters, i.e. PaddingValues(), do not change.

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:22PM

Assigned to po...@google.com.

ap...@google.com <ap...@google.com> #2Apr 20, 2021 09:50AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

Issue 181336792