Modifier.graphicsLayer should provide size information [181387080]

Fixed

Bug

Status Update

No update yet.

Description

da...@danielzfranklin.org

created issue #1

Feb 28, 2021 05:15PM

Version used: 1.0.0-alpha12, but I've confirmed it isn't fixed in the latest version on cs.android.com

I want to access the current size in Modifier.graphicsLayer

I want to be able to write code like this

fun Modifier.turnedPage(turnPercent: Float) = graphicsLayer {
  val width = ???
  translationX = -turnPercent * width.toFloat()
  // ...
}

Instead, because GraphicsLayerScope doesn't have any size information, I have to write code like this

fun Modifier.myModifier(...) = composed {
  var size by remember { mutableStateOf(IntSize.Zero) }

  Modifier.onSizeChanged { size = it }
    .graphicsLayer {
      val width = size.width
      translationX = -turnPercent * width.toFloat()
      // ...
    }
}

I'm filing an issue because Adam Powell suggested it on slack)

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:21PM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #2Nov 1, 2022 03:09AM

Marked as fixed.

Related CLs

These are the CLs related to this project that were merged before filing this bug, mostly in chronological order.

Adding support for multiple text input systems. aosp/2406439
Copy EditProcessor, EditingBuffer and EditCommand to foundation demo app. aosp/2401358
WIP BasicTextInputPlugin, BasicTextField2, TextFieldState aosp/2450923
Stabilize PlatformTextInput API to allow use from Foundation. aosp/2465156
Make LocalPlatformTextInputPluginRegistry non-experimental. aosp/2466795
Always use EditProcessor.update method for setText semantics action in BTF2. aosp/2485833
Move BasicTextField2 prototype and tests to foundation. aosp/2475185
Disable a broken test in BasicTextField2 aosp/2487271
Continue expanding BTF2 API with DecorationBox aosp/2480257
Attempt to fix a flaky test for BasicTextField selection aosp/2493878
Add semantics action for inserting text at cursor. aosp/2481301
Move most BasicTextField2 decoration box modifiers to a Modifier.Node. aosp/2494377
KeyEvent support for BasicTextField2 aosp/2485061
Kick-off using Modifier Nodes in BasicTextField2 core modifiers aosp/2497299
Add Scroll capability to BasicTextField2 aosp/2506069
Simplify the BasicTextField2 package structure. aosp/2513916
Add some hooks to integration test full pipeline from BTF2 to platform. aosp/2515797
Implement basic TextFieldState.edit. aosp/2500547
Move filter from property on TextFieldState to param on BasicTextField2. aosp/2512127
Address nit feedback on aosp/2512127 and aosp/2500547. aosp/2516839
Give TextFieldState a Saver object and rememberTextFieldState. aosp/2520395
Make TextEditFilter use MutableTextFieldValueWithSelection. aosp/2513918
KeyboardActions in BasicTextField2 aosp/2518475
Add keyboard visibility controls to TextInputSession aosp/2518476
Add change tracking to MutableTextFieldValue. aosp/2513915
Improve TextFieldKeyEventTest for BasicTextField2 aosp/2513576
Disable some BasicTextField2 tests on API21 aosp/2524362
Replace MutableTextFieldValueWithSelection.resetTo with revertAllChanges. aosp/2526345
Add the ability for TextEditFilters to specify default keyboard options. aosp/2523357
Combine min/max lines into a single parameter. aosp/2523359
- Revert "Combine min/max lines into a single parameter." aosp/2528167
- Revert "Revert "Combine min/max lines into a single parameter."" aosp/2528168
Make TextRange.constrain public. aosp/2528163
Introduce BasicSecureTextField in text2 aosp/2519909
Remove the system settings check from BasicSecureTextField. aosp/2528482
Get TextFieldValue out of public BasicTextField2 API. aosp/2526539
Rename selection to selectionInChars. aosp/2528164

na...@google.com <na...@google.com> #3Nov 9, 2022 06:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8243c6ccdf7a97c51f3424d8a3872767d309cf57
Author: Zach Klippenstein <klippenstein@google.com>
Date: Fri Apr 07 11:14:52 2023

Misc polish for BTF2 APIs.

- Renamed TextFieldEditResult to TextEditResult to be more concise and
match TextEditFilter.
- Added placeCursorAfter{Char|Codepoint}At methods to both
TextEditResult and MutableTextFieldValueWithSelection.
- Added more docs.

Bug:

b/277380808

Test: existing coverage
Relnote: n/a
Change-Id: Ic2d4a7d907d9a3c091a2ef4131b906af701b6e42

M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text2/BasicTextField2FilterDemos.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BasicTextField2Samples.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2Test.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/BasicSecureTextField.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/AllCapsFilter.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/MaxLengthFilter.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextEditFilter.kt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextEditResult.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldBufferWithSelection.kt
D compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldEditResult.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldState.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/EditProcessor.kt

https://android-review.googlesource.com/2528481

Issue 181387080

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:21PM

ap...@google.com <ap...@google.com> #2Nov 1, 2022 03:09AM

Related CLs

na...@google.com <na...@google.com> #3Nov 9, 2022 06:28PM

Add comment

Issue metadata