Modifier.graphicsLayer should provide size information [181387080]

Fixed

Bug

Status Update

No update yet.

Description

da...@danielzfranklin.org

created issue #1

Feb 28, 2021 05:15PM

Version used: 1.0.0-alpha12, but I've confirmed it isn't fixed in the latest version on cs.android.com

I want to access the current size in Modifier.graphicsLayer

I want to be able to write code like this

fun Modifier.turnedPage(turnPercent: Float) = graphicsLayer {
  val width = ???
  translationX = -turnPercent * width.toFloat()
  // ...
}

Instead, because GraphicsLayerScope doesn't have any size information, I have to write code like this

fun Modifier.myModifier(...) = composed {
  var size by remember { mutableStateOf(IntSize.Zero) }

  Modifier.onSizeChanged { size = it }
    .graphicsLayer {
      val width = size.width
      translationX = -turnPercent * width.toFloat()
      // ...
    }
}

I'm filing an issue because Adam Powell suggested it on slack)

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:21PM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #2Nov 1, 2022 03:09AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7f1905b9b1d090c837d6cba348152026f087c4ed
Author: Nader Jawad <njawad@google.com>
Date: Sun Oct 30 20:09:27 2022

Include size within GraphicsLayerScope

Relnote: "Updated GraphicsLayerScope to
expose the current size of the graphicsLayer.
This is useful for computing graphicsLayer
transformations as a function of the Composable
size."

Fixes: 181387080
Test: Added tests to GraphcisLayerTest and
GraphicsLayerScopeTest

Change-Id: If8c43dad95441ba7cc7ddc845bfa502cce688c7b

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/GraphicsLayerTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/graphics/GraphicsLayerScope.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeCoordinator.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/graphics/GraphicsLayerScopeTest.kt

https://android-review.googlesource.com/2278006

na...@google.com <na...@google.com> #3Nov 9, 2022 06:28PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.4.0-alpha02

Issue 181387080

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:21PM

ap...@google.com <ap...@google.com> #2Nov 1, 2022 03:09AM

na...@google.com <na...@google.com> #3Nov 9, 2022 06:28PM

Add comment

Issue metadata