Modifier.graphicsLayer should provide size information [181387080]

Fixed

Bug

Status Update

No update yet.

Description

da...@danielzfranklin.org

created issue #1

Feb 28, 2021 05:15PM

Version used: 1.0.0-alpha12, but I've confirmed it isn't fixed in the latest version on cs.android.com

I want to access the current size in Modifier.graphicsLayer

I want to be able to write code like this

fun Modifier.turnedPage(turnPercent: Float) = graphicsLayer {
  val width = ???
  translationX = -turnPercent * width.toFloat()
  // ...
}

Instead, because GraphicsLayerScope doesn't have any size information, I have to write code like this

fun Modifier.myModifier(...) = composed {
  var size by remember { mutableStateOf(IntSize.Zero) }

  Modifier.onSizeChanged { size = it }
    .graphicsLayer {
      val width = size.width
      translationX = -turnPercent * width.toFloat()
      // ...
    }
}

I'm filing an issue because Adam Powell suggested it on slack)

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:21PM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #2Nov 1, 2022 03:09AM

Marked as fixed.

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

na...@google.com <na...@google.com> #3Nov 9, 2022 06:28PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

Issue 181387080

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:21PM

ap...@google.com <ap...@google.com> #2Nov 1, 2022 03:09AM

na...@google.com <na...@google.com> #3Nov 9, 2022 06:28PM

Add comment

Issue metadata