Modifier.graphicsLayer should provide size information [181387080]

Fixed

Bug

Status Update

No update yet.

Description

da...@danielzfranklin.org

created issue #1

Feb 28, 2021 05:15PM

Version used: 1.0.0-alpha12, but I've confirmed it isn't fixed in the latest version on cs.android.com

I want to access the current size in Modifier.graphicsLayer

I want to be able to write code like this

fun Modifier.turnedPage(turnPercent: Float) = graphicsLayer {
  val width = ???
  translationX = -turnPercent * width.toFloat()
  // ...
}

Instead, because GraphicsLayerScope doesn't have any size information, I have to write code like this

fun Modifier.myModifier(...) = composed {
  var size by remember { mutableStateOf(IntSize.Zero) }

  Modifier.onSizeChanged { size = it }
    .graphicsLayer {
      val width = size.width
      translationX = -turnPercent * width.toFloat()
      // ...
    }
}

I'm filing an issue because Adam Powell suggested it on slack)

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:21PM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #2Nov 1, 2022 03:09AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 755b3f1f06c682b37c39b7bf3b80bccb638b642d
Author: Nader Jawad <njawad@google.com>
Date: Mon Feb 12 23:43:23 2024

GraphicsLayer API Part 4/N

Relnote: "Update Compose framework to expose a
GraphicsContext composition local alongside
updating Owner, DelegateableNode and drawWithCache
Modifier implementations to expose access to the
GraphicsContext for scoped access that will automatically
cleanup GraphicsLayer instances when Modifiers are torn
down."

Bug: 288494724
Test: Ran AndroidGraphicsLayerTest
Change-Id: I64a2f6a2e156f9305fe32ac2a6f9be2b61f7f0ed

M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawScope.kt
M compose/ui/ui-unit/api/current.txt
M compose/ui/ui-unit/api/restricted_current.txt
M compose/ui/ui-unit/src/androidUnitTest/kotlin/androidx/compose/ui/unit/IntSizeTest.kt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/IntSize.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/draw/DrawModifierTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/input/pointer/HitPathTrackerTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/layout/Helpers.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/node/NodeChainTester.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
M compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/ModifierLocalConsumerEntityTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draw/DrawModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/graphics/GraphicsLayerScope.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/DelegatableNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaBasedOwner.skiko.kt

https://android-review.googlesource.com/2960247

na...@google.com <na...@google.com> #3Nov 9, 2022 06:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 88951ea1f54623398ffdac8a24e35db3fbfeeb8a
Author: Nader Jawad <njawad@google.com>
Date: Mon Feb 12 22:54:56 2024

GraphicsLayer API Part 3/N

Relnote: "Introduce GraphicsContext function constructor
to create a factory to create GraphicsLayer instances"

Created GraphicsLayerV29 as the RenderNode backed
GraphicsLayer for Android

Bug: 288494724
Test: Added AndroidGraphicsLayerTest
Change-Id: Ib98d6b140fab3d857f74faa4fa227927e1625bed

M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
A compose/ui/ui-graphics/src/androidInstrumentedTest/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayerTest.kt
A compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidGraphicsContext.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayer.android.kt
A compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV29.android.kt

https://android-review.googlesource.com/2960246

Issue 181387080

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> Mar 4, 2021 12:21PM

ap...@google.com <ap...@google.com> #2Nov 1, 2022 03:09AM

na...@google.com <na...@google.com> #3Nov 9, 2022 06:28PM

Add comment

Issue metadata