Heif images bring down entire iOS image rendering [181554690]

Assigned

Bug

Status Update

No update yet.

Description

sj...@gmail.com

created issue #1

Mar 1, 2021 07:14PM

Version used: 1.1.0-alpha01 Devices/Android versions reproduced on: iOS 14

Our app Blink is using Heifwriter to create profile pictures from Android User's camera roll, which can be seen on our iOS app. Some images cause iOS users to enter a corrupt state, simply by viewing/rendering within the app. This catastrophic failure not only affects all image rendering in our app, but extends to the entire operating system (including apps like Apple App Store). The only reliable fix seems to be a full restart to fix.

More details here: https://github.com/kean/Nuke/issues/440

Here's the code we use to generate the image, and attached is one of the images that can cause image rendering to fail (generated with this code).

fun convertToHEIC(context: Context, path: String, size: Int) : ByteArray? {
            if (android.os.Build.VERSION.SDK_INT < android.os.Build.VERSION_CODES.P) {
                return null
            }
            val bitmap = BitmapFactory.decodeStream(FileInputStream(File(path)))
            var imageHeight = bitmap.height
            var imageWidth = bitmap.width
            if (size < imageWidth) {
                val factor = size * 1.0 / imageWidth
                imageHeight = floor(factor * imageHeight).toInt()
                imageWidth = floor(factor * imageWidth).toInt()
            }
            val outputDir: File = context.cacheDir // context being the Activity pointer
            val outputFile = File.createTempFile(UUID.randomUUID().toString(), "heic", outputDir)
            // Step 2: Create HEIF Writer instance & convert
            try {
                HeifWriter.Builder(outputFile.path, imageWidth, imageHeight, HeifWriter.INPUT_MODE_BITMAP)
                    .setQuality(90)             // Set Quality range [0,100]
                    .build().run {
                        start()
                        addBitmap(bitmap)       // addBitmap if the writer is using INPUT_MODE_BITMAP
                        stop(0)     // 0: mean infinitely running
                        close()                 // Close after use.
                    }
            } catch (ex: Exception) {
                // Throw exception in case the device is not supported like Android not above of 9.0 or cause by using Emulator
                ex.printStackTrace()
                return null
            }
            val content = outputFile.readBytes()
            outputFile.delete()
            return content
        }

641ece96-355d-47ce-84fd-a748ba421560.heic

236 KB

View

Download

Comments

sj...@gmail.com <sj...@gmail.com> #2Mar 1, 2021 07:21PM

We gave up upgrading to Room because we need to use FTS3/FTS4 virtual tables. Any plants to support it?

heifwriter-failure.png

2.7 MB

View

Download

ch...@google.com <ch...@google.com> #3Mar 1, 2021 10:32PM

Reassigned to sj...@gmail.com.

Florina Muntenescu (Android developer advocate at Google) told me that FTS support will definitely NOT be in Room 1.0 final. It is postponed to an indeterminate later version.

ch...@google.com <ch...@google.com> #4Mar 1, 2021 10:34PM

It is possible to work with virtual tables and fts4 while using Room v1. You just need to create and access it by yourself using sql queries. Not perfect but it works for me (just did it a few days ago).
Can't wait for this feature to be in Room

sj...@gmail.com <sj...@gmail.com> #5Mar 1, 2021 11:01PM

If your FTS tables are separate from the rest of your model it's a viable solution. Mine are fully integrated with my model (almost all queries have JOINs with virtual tables) so it's a no-go.

ch...@google.com <ch...@google.com> #6Mar 1, 2021 11:19PM

any news?

sj...@gmail.com <sj...@gmail.com> #7Mar 2, 2021 12:20AM

I'm really looking forward to use FTS natively with Room. Can you give some kind of roadmap? E.g. is it considered for Room 1.2 or Room 2.0?

sj...@gmail.com <sj...@gmail.com> #8Mar 11, 2021 10:46PM

Using FTS should not block you from using room, you just cannot use compile time checked queries (you can still use them in RawQuery though).

ba...@gmail.com <ba...@gmail.com> #9Mar 12, 2021 12:24PM

Thanks for the fast answer, Yigit. I'm more then happy to not have to work with RawQuery's anymore, and I don't want to jump back to it for using FTS.

Based on your answer I would guess that it's delayed / postponed any longer, cause it's already working with this kind of workaround?

ch...@google.com <ch...@google.com> #10Mar 12, 2021 03:33PM

> Using FTS should not block you from using room, you just cannot use compile time checked queries (you can still use them in RawQuery though).

We cannot declare an FTS table using Room entities, as there are no options for that. So, are you suggesting that we should create and manage this table manually, but still use a Room DAO for access?

ch...@google.com <ch...@google.com> #11Mar 12, 2021 04:33PM

on the ETA: Sorry I cannot give one yet because we've not done the prioritization meeting for post IO.

#10: yes that is a workaround that you can do right now. It is not great but RawQuery will still properly work since it allows you to return any pojo. Probably it is better to isolate these into their custom dao which can use a protected RawQuery method and provide public APIs like any other dao.

sj...@gmail.com <sj...@gmail.com> #12Mar 12, 2021 07:05PM

Still can't support it now?

jl...@gmail.com <jl...@gmail.com> #13May 6, 2021 01:19AM

look forward to the new feature to be supported in ROOM!!

sj...@gmail.com <sj...@gmail.com> #14May 21, 2021 06:20PM

Is FTS now supported in Room?

sj...@gmail.com <sj...@gmail.com> #15Aug 12, 2021 07:13AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 07f547ca76ad20790b51b52bf969d45b6070295a
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Aug 20 13:24:31 2018

Room FTS Support - Annotations

Created Fts3Entity & Fts4Entity annotations to declare a class as an
entity of an FTS table. FTS options are supported through annotation
parameters.

Bug: 62356416
Test: N/A
Change-Id: Ic627e38fd3ee5b1138146c2d1fd69e2a2f1365a1

M room/common/api/current.txt
A room/common/src/main/java/androidx/room/Fts3Entity.java
A room/common/src/main/java/androidx/room/Fts4Entity.java
A room/common/src/main/java/androidx/room/FtsOptions.java

https://android-review.googlesource.com/735152

https://goto.google.com/android-sha1/07f547ca76ad20790b51b52bf969d45b6070295a

sj...@gmail.com <sj...@gmail.com> #16Aug 18, 2021 11:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 94867f06a611c3ada3dc95aa394d9e8485be2db5
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Aug 20 13:38:26 2018

Room FTS Support - Processor

Created FtsEntityProcessor to process classes annotated with @FtsEntity.
EntityProcessor & FtsEntityProcessor now implement a common interface
BaseEntityProcessor that will either create the Entity or FtsEntity
value object based on the element annotation. FtsEntity extends Entity
which keep intact most of the Entity class reference around the compiler
code .

Created migration bundle class for FtsEntity to later handle migration.

Bug: 62356416
Test: ./gradlew room:room-compiler:test \
room:integration-tests:testapp:cC

Change-Id: I867635165b7e1dcb37806273c1c097fa4f450408

M room/compiler/src/main/kotlin/androidx/room/ext/element_ext.kt
M room/compiler/src/main/kotlin/androidx/room/parser/SqlParser.kt
A room/compiler/src/main/kotlin/androidx/room/processor/BaseEntityProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/DatabaseProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/FieldProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/processor/FtsTableEntityProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/compiler/src/main/kotlin/androidx/room/processor/RawQueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ShortcutMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ShortcutParameterProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/TableEntityProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/vo/Entity.kt
A room/compiler/src/main/kotlin/androidx/room/vo/FtsEntity.kt
A room/compiler/src/main/kotlin/androidx/room/vo/FtsOptions.kt
A room/compiler/src/main/kotlin/androidx/room/vo/LanguageId.kt
M room/compiler/src/main/kotlin/androidx/room/vo/Pojo.kt
M room/compiler/src/test/kotlin/androidx/room/processor/BaseEntityParserTest.kt
A room/compiler/src/test/kotlin/androidx/room/processor/BaseFtsEntityParserTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/FieldProcessorTest.kt
A room/compiler/src/test/kotlin/androidx/room/processor/Fts3TableEntityProcessorTest.kt
A room/compiler/src/test/kotlin/androidx/room/processor/Fts4TableEntityProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/TableEntityProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/compiler/src/test/kotlin/androidx/room/verifier/DatabaseVerifierTest.kt
M room/compiler/src/test/kotlin/androidx/room/vo/EntityTest.kt
A room/compiler/src/test/kotlin/androidx/room/vo/FtsEntityTest.kt
M room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/TestDatabase.java
A room/integration-tests/autovaluetestapp/src/androidTest/java/androidx/room/integration/autovaluetestapp/vo/Mail.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/TestDatabase.java
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/MailDao.java
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/FtsTableTest.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/TestDatabaseTest.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/TestUtil.java
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/vo/Mail.java
M room/migration/src/main/java/androidx/room/migration/bundle/EntityBundle.java
A room/migration/src/main/java/androidx/room/migration/bundle/FtsEntityBundle.java
A room/migration/src/main/java/androidx/room/migration/bundle/FtsOptionsBundle.java

https://android-review.googlesource.com/735153

https://goto.google.com/android-sha1/94867f06a611c3ada3dc95aa394d9e8485be2db5