Add @Composable lambda for Snackbar message to SnackbarHostState.showSnackbar [181576279]

Assigned

Feature Request

compose-roadmap-proposal

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Mar 1, 2021 08:43PM

There are two reasons why I would like to see this added:

Style Snackbar message using AnnotatedString.
Use string resources with stringResource. You need a Compose lambda for that as stringResource is annotated with @Composable.

The function would look something like this (in SnackbarHostState):

suspend fun showSnackbar(
    message: @Composable () -> Unit,
    actionLabel: (@Composable () -> Unit)? = null,
    duration: SnackbarDuration = SnackbarDuration.Short
): SnackbarResult

Example code using this new function:

@Composable
fun Sample() {
    val scope = rememberCoroutineScope()
    val scaffoldState = rememberScaffoldState()
    Scaffold(
        scaffoldState = scaffoldState,
        content = {
            Button(
                onClick = {
                    scope.launch {
                        // DOES NOT COMPILE
                        scaffoldState.snackbarHostState.showSnackbar(
                            message = {
                                Text(
                                    text = buildAnnotatedString {
                                        pushStyle(SpanStyle(fontWeight = FontWeight.Bold))
                                        append(stringResource(R.string.my_custom_message))
                                        pop()
                                    }
                                )
                            }
                        )
                    }
                }
            ) {
                Text("Show snackbar")
            }
        }
    )
}

See for more information: https://kotlinlang.slack.com/archives/CJLTWPH7S/p1610053528286000

Comments

th...@gmail.com <th...@gmail.com> #2Mar 1, 2021 08:52PM

Hello, can you please attach a sample that reproduces your error?

Screenshot_20210301-214932.jpg

32 KB

View

Download

ni...@google.com <ni...@google.com> #3Jun 15, 2021 01:09PM

Status: New

I’ve attached two screen recordings demonstrating the mediator's behavior during the first and second launches after installation. Additionally, https://gist.github.com/yatiksihag01/20106aa4855bd438e3eb982034d4bb7d is link to a GitHub Gist containing the code for my remote mediator file for your reference.

ma...@google.com <ma...@google.com> #4Jun 18, 2021 11:11AM

Assigned to je...@google.com.

Based on first_launch_after_installation.mp4, your paging state is indeed showing null for nextKey, so it makes sense that Paging concluded there are no more items to load.

So I think the question is why the PagingState contains only an empty page and null values. My guess is either

RemoteMediator REFRESH actually returned empty data - what is the returned allNewsItems value on initial REFRESH?
RemoteMediator REFRESH successfully loaded data and inserted it into database, but Paging hasn't processed that yet by the time Append is triggered, so PagingState is empty.

The second case doesn't seem likely though.

If you attach an executable app, I can look into this further.

Otherwise, you may gain more insight through Paging logs with adb shell setprop log.tag.Paging VERBOSE. You can also try implementing RemoteKeys in this codelab which addresses possible races between Refresh and subsequent loads.

ni...@gmail.com <ni...@gmail.com> #5Oct 13, 2021 12:53PM

Hey! I ran into this same issue. It is in fact the second case you mentioned and is documented here.

I've published a repo reproducing the issue and filed a ticket proposing how this could be changed.

th...@gmail.com <th...@gmail.com> #6Apr 22, 2022 08:59PM

It seems that with material3 you can provide a custom SnackbarVisuals class to showSnackbar function. Then you can change how the snackbar looks in SnackbarHost block based on whether a custom visuals class is passed. That is good enough for me as it allows to customise the snackbar style, thanks for adding it!

th...@gmail.com <th...@gmail.com> #7Apr 22, 2022 09:01PM

Still, a function similar to which I proposed in comment #1 would be nice, as that would still simplify this a lot.

se...@google.com <se...@google.com> #8Jun 8, 2023 06:33PM

Reassigned to sg...@google.com.

Shalom do you think it is reasonable to "backport" SnackbarVisuals in M2, provided the existing functionality continues to exist as well.

se...@google.com <se...@google.com> #9Jun 8, 2023 06:34PM

Also, de-prioritized for now because SnackbarVisuals allows your for your requested behavior.

jo...@gmail.com <jo...@gmail.com> #10Aug 16, 2023 04:27PM

I can open a new issue for this if requested but SnackbarVisuals still doesn't let you use AnnotatedString for (at least) the Snackbar message. Without this, we can't style text with emphasis such as italics, bold, etc. Please adjust the API to allow callers to specify an AnnotatedString for message and hopefully, actionLabel.