Exception when creating a ViewModel for a View in a Fragment - IllegalStateException: Internal error: OnRecreation should be registered only on componentsthat implement ViewModelStoreOwner [181577191]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

Mar 2, 2021 12:15PM

Component used: lifecycle-viewmodel-ktx

Version used: 2.3.0

Devices/Android versions reproduced on: Pixel 4 running Android 10

Sample project to trigger the issue: https://github.com/tfcporciuncula/view-tree-owner-bug

You can repro the issue by cloning that repo, running it, and then rotating the screen causing a config change.

This is the code I'm using to create a ViewModel in a View (as you can see here):

private val viewModel by lazy {
  val factory = object : AbstractSavedStateViewModelFactory(findViewTreeSavedStateRegistryOwner()!!, null) {
    override fun <T : ViewModel?> create(key: String, modelClass: Class<T>, handle: SavedStateHandle): T {
      return MyViewModel() as T
    }
  }
  ViewModelProvider(findViewTreeViewModelStoreOwner()!!, factory).get(MyViewModel::class.java)
}

Everything works fine, but the app crashes on orientation change with the following stacktrace:

Process: com.tfcporciuncula.viewtreeownerbug, PID: 3467
    java.lang.IllegalStateException: Internal error: OnRecreation should be registered only on componentsthat implement ViewModelStoreOwner
        at androidx.lifecycle.SavedStateHandleController$OnRecreation.onRecreated(SavedStateHandleController.java:80)
        at androidx.savedstate.Recreator.reflectiveNew(Recreator.java:92)
        at androidx.savedstate.Recreator.onStateChanged(Recreator.java:64)
        at androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.java:354)
        at androidx.lifecycle.LifecycleRegistry.forwardPass(LifecycleRegistry.java:265)
        at androidx.lifecycle.LifecycleRegistry.sync(LifecycleRegistry.java:307)
        at androidx.lifecycle.LifecycleRegistry.moveToState(LifecycleRegistry.java:148)
        at androidx.lifecycle.LifecycleRegistry.handleLifecycleEvent(LifecycleRegistry.java:134)
        at androidx.fragment.app.FragmentViewLifecycleOwner.handleLifecycleEvent(FragmentViewLifecycleOwner.java:62)
        at androidx.fragment.app.Fragment.restoreViewState(Fragment.java:650)
        at androidx.fragment.app.Fragment.restoreViewState(Fragment.java:2997)
        at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:2988)
        at androidx.fragment.app.FragmentStateManager.activityCreated(FragmentStateManager.java:577)
        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:285)
        at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:112)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1636)
        at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3112)
        at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:3056)
        at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:251)
        at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:473)
        at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:210)
        at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1425)
        at android.app.Activity.performStart(Activity.java:7825)
        at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3294)
        at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:221)
        at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201)
        at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2016)
        at android.os.Handler.dispatchMessage(Handler.java:107)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

The crash has a pretty clear cause which is this:

if (!(owner instanceof ViewModelStoreOwner)) {
    throw new IllegalStateException(
            "Internal error: OnRecreation should be registered only on components"
                    + "that implement ViewModelStoreOwner");
}

So it seems there's this implicit requirement of having the SavedStateRegistryOwner also be a ViewModelStoreOwner, and that's not the case for the view when it's in a fragment: its SavedStateRegistryOwner is a FragmentViewLifecycleOwner, which is only a SavedStateRegistryOwner and not a ViewModelStoreOwner.

It feels like findViewTreeSavedStateRegistryOwner() should return the fragment itself (like findViewTreeSavedStateRegistryOwner()) instead of the FragmentViewLifecycleOwner, so this would work. Or am I doing something wrong here?

If the view is in an activity everything works fine -- findViewTreeSavedStateRegistryOwner() returns the activity in this case, which is also a ViewModelStoreOwner so everything is good.

Comments

il...@google.com <il...@google.com> #2Mar 2, 2021 05:18PM

Reassigned to il...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Mar 2, 2021 08:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit d938453e52702fb48836cbf08b751c6354a734dc
Author: Ian Lake <ilake@google.com>
Date: Tue Mar 02 10:57:20 2021

Let FragmentViewLifecycleOwner implement ViewModelStoreOwner

SavedStateViewModelFactory makes some assumptions that
the SavedStateRegistryOwner is also a ViewModelStoreOwner.
This is almost always the case, except when using the
ViewTree APIs in Fragments. This change makes it so
that the internal FragmentViewLifecycleOwner that is
tied to the Fragment's View Lifecycle implements
ViewModelStoreOwner as well (delegating to the Fragment's
ViewModelStore).

Relnote: "Using `SavedStateViewModelFactory` now works
when used with the `SavedStateRegistryOwner` returned by
using `findViewTreeSavedStateRegistryOwner()` from a
Fragment's View."
Test: updated tests pass
BUG: 181577191

Change-Id: I21acf18f70ab6dcc60f5946d5b0d878e12bc76df

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewLifecycleTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentViewLifecycleOwner.java

https://android-review.googlesource.com/1612805

il...@google.com <il...@google.com> #4Mar 2, 2021 08:38PM

Marked as fixed.

This has been fixed internally and we're looking to include it in the Fragment 1.3.1 release.

tf...@gmail.com <tf...@gmail.com> #5Mar 24, 2021 09:54PM

Are there any plans to include this in any of the next releases? I just checked 1.3.2 and it doesn't seem to be there.

il...@google.com <il...@google.com> #6Mar 24, 2021 10:53PM

Sorry, looks like this slipped through the cracks. I'll actually add this to the next release's hotlist.

b9...@gmail.com <b9...@gmail.com> #7Apr 22, 2021 03:27PM

I upgrade 1.3.3 from 1.3.2 and can't create ViewModel in compose via androidx.lifecycle.viewmodel.compose.viewModel<T>() anymore.

il...@google.com <il...@google.com> #8Apr 22, 2021 03:28PM

Re #7 - please file a new bug with a sample project that reproduces your issue.

b9...@gmail.com <b9...@gmail.com> #9Apr 22, 2021 05:28PM

Re #8 I could point out the code directly. I don't know how to describe the issue.

    public ViewModelProvider(@NonNull ViewModelStoreOwner owner) {
        this(owner.getViewModelStore(), owner instanceof HasDefaultViewModelProviderFactory
                ? ((HasDefaultViewModelProviderFactory) owner).getDefaultViewModelProviderFactory()
                : NewInstanceFactory.getInstance());
    }

ViewModel compose extension use this constructor by default. Because FragmentViewLifecycleOwner didn't implement HasDefaultViewModelProviderFactory, so that NewInstanceFactory will be used to create ViewModel. Which means DI framework like Hilt will failed.

il...@google.com <il...@google.com> #10Apr 22, 2021 05:31PM

Re #9 - please file a new bug so we can track that work.

b9...@gmail.com <b9...@gmail.com> #11Apr 22, 2021 06:02PM

Re #10, here it is