Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 2dd54786f8d2b11189c176e7fb76de050266422e
Author: Matvei Malkov <malkov@google.com>
Date: Tue Mar 02 14:23:47 2021
Resolve experimental API violations in Drawer APIs
There is a vialotaion of experimental rules in drawer APIs that we need to fix:
* Even though BottomDrawer itself marked as experimental, its state (BottomDrawerState) is not, which is inconsistent
* DrawerState extends SwipeableState, which is an experimental class. Public classes cannot extend experimental ones, so we need to remove the hierarchy and inline majority of methods to preverse source compatibility
Change-Id: I81114f9ba3762dfa162368be2b812b24d1d788e3
Relnote: "API CHANGE: DrawerState state is no longer extends experimental SwipeableState."
Relnote: "API CHANGE: BottomDrawerState is now marked as Experimental, to match already Experiemntal BottomDrawer component"
Test: added for new fields
Fixes: 181656094
M compose/material/material/api/1.0.0-beta04.txt
A compose/material/material/api/current.ignore
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_1.0.0-beta04.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_1.0.0-beta04.txt
A compose/material/material/api/restricted_current.ignore
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/DrawerTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
https://android-review.googlesource.com/1613082
Branch: androidx-main
commit 2dd54786f8d2b11189c176e7fb76de050266422e
Author: Matvei Malkov <malkov@google.com>
Date: Tue Mar 02 14:23:47 2021
Resolve experimental API violations in Drawer APIs
There is a vialotaion of experimental rules in drawer APIs that we need to fix:
* Even though BottomDrawer itself marked as experimental, its state (BottomDrawerState) is not, which is inconsistent
* DrawerState extends SwipeableState, which is an experimental class. Public classes cannot extend experimental ones, so we need to remove the hierarchy and inline majority of methods to preverse source compatibility
Change-Id: I81114f9ba3762dfa162368be2b812b24d1d788e3
Relnote: "API CHANGE: DrawerState state is no longer extends experimental SwipeableState."
Relnote: "API CHANGE: BottomDrawerState is now marked as Experimental, to match already Experiemntal BottomDrawer component"
Test: added for new fields
Fixes: 181656094
M compose/material/material/api/1.0.0-beta04.txt
A compose/material/material/api/current.ignore
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_1.0.0-beta04.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_1.0.0-beta04.txt
A compose/material/material/api/restricted_current.ignore
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/DrawerTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
Description
there are 2 API violations that we need to fix.