Target Fragment deprecation on Fragment [181793702]

Assigned

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Mar 4, 2021 03:35PM

Component used: PreferenceDialogFragmentCompat

Version used: 1.1.1

Problem

On the 1.3.0 version of the androidx fragment library the setTargetFragment is deprecated, now the results of the fragments should be via a result callback.

The problem that I’m seeing with this deprecation is that on the PreferenceDialogFragmentCompat onCreate we need the targetFragment to be set.

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    final Fragment rawFragment = getTargetFragment();
    if (!(rawFragment instanceof DialogPreference.TargetFragment)) {
        throw new IllegalStateException("Target fragment must implement TargetFragment" + " interface");
    }
    final DialogPreference.TargetFragment fragment = (DialogPreference.TargetFragment) rawFragment;

This will make a compiler warning for each time we need to show a PreferenceDialog.

Comments

af...@doist.com <af...@doist.com> #2Feb 2, 2022 06:41PM

My dependencies:

    implementation 'androidx.appcompat:appcompat:1.4.0'
    implementation 'androidx.preference:preference:1.1.1'
    implementation 'com.google.android.gms:play-services-wearable:17.1.0'
    implementation 'com.google.android.material:material:1.4.0'

If I remove androidx.appcompat:appcompat:1.4.0, the warning vanishes, so I imagine there's some transitive dependency on an older version of androidx.appcompat:appcompat that doesn't have the warning.

lp...@google.com <lp...@google.com> #3Feb 3, 2022 12:09AM

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:preference/preference/src/main/java/androidx/preference/PreferenceDialogFragmentCompat.java;l=53;drc=ca9feb3b73769089afbfd36b4d4a3d91239f9cd5;bpv=1;bpt=0

af...@gmail.com <af...@gmail.com> #4Feb 3, 2022 10:53PM

The upstream library is using @SuppressWarnings("deprecation"), which I suppose you could probably use to suppress the warning you're getting.

As for doing fully the non-deprecated way, it is possible that would require overwriting/duplicating more functionality than you currently are and/or updates to the Preference library.

However, I suspect that FragmentManager is capable of handling Fragment subclasses. You should probably look for instructions on developer.android.com, stackoverflow, or similar.

pa...@gmail.com <pa...@gmail.com> #5Mar 16, 2023 10:08AM

Looks like a duplicate of https://issuetracker.google.com/issues/181793702, ow...@google.com I proposed a "solution" to this in the other issue.

Issue 181793702

Description

Issue summary

Comments

af...@doist.com <af...@doist.com> #2Feb 2, 2022 06:41PM

lp...@google.com <lp...@google.com> #3Feb 3, 2022 12:09AM

af...@gmail.com <af...@gmail.com> #4Feb 3, 2022 10:53PM

pa...@gmail.com <pa...@gmail.com> #5Mar 16, 2023 10:08AM

Add comment

Issue metadata