Fixed
Status Update
Comments
mi...@google.com <mi...@google.com>
ha...@google.com <ha...@google.com> #2
I think I accidentally replaced the title with a '!' while submitting the bug report and I can't really find a way to rename the title now. The actual title for this issue was supposed to be 'Too much delay between flashes taken during image capture (on Pixel 3a)'.
Extremely sorry for the inconvenience and thanks a lot for the help and support!
Regards,
Mohit
ha...@google.com <ha...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit b7c30d6a48df58b703557bcc9b510a2bc2dc6cdc
Author: Scott Nien <scottnien@google.com>
Date: Thu Dec 23 16:50:52 2021
Use torch as flash on Pixel 3a/Pixel 3a XL
The flash sequence using AE precapture on Pixel
3a and Pixel 3a XL is slow and often cause the image
to be blurred.
Using torch as the flash will achieve a better image.
Relnote: "Use torch as flash on Pixel 3a/Pixel 3a XL
to improve the speed and the captured image quality
in dark"
Bug: 211474332
Test: FlashTooSlowQuirkTest
Change-Id: Ib12b6f948e545a1b33862e14db8bb4d989032fa6
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/AutoFlashUnderExposedQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/FlashTooSlowQuirk.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/FlashTooSlowQuirkTest.kt
https://android-review.googlesource.com/1932737
Branch: androidx-main
commit b7c30d6a48df58b703557bcc9b510a2bc2dc6cdc
Author: Scott Nien <scottnien@google.com>
Date: Thu Dec 23 16:50:52 2021
Use torch as flash on Pixel 3a/Pixel 3a XL
The flash sequence using AE precapture on Pixel
3a and Pixel 3a XL is slow and often cause the image
to be blurred.
Using torch as the flash will achieve a better image.
Relnote: "Use torch as flash on Pixel 3a/Pixel 3a XL
to improve the speed and the captured image quality
in dark"
Bug: 211474332
Test: FlashTooSlowQuirkTest
Change-Id: Ib12b6f948e545a1b33862e14db8bb4d989032fa6
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/AutoFlashUnderExposedQuirk.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/FlashTooSlowQuirk.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/FlashTooSlowQuirkTest.kt
ha...@google.com <ha...@google.com> #4
Hi Mohit,
Thanks for filing the issue. After investigation, yes it is slow when capturing with flash in dark. So we changed it to use torch as the flash instead. The results shows using torch not just can be quicker but also the quality is better than using flash. The Jan release will contain the fix.
Scott
Thanks for filing the issue. After investigation, yes it is slow when capturing with flash in dark. So we changed it to use torch as the flash instead. The results shows using torch not just can be quicker but also the quality is better than using flash. The Jan release will contain the fix.
Scott
nt...@google.com <nt...@google.com>
nt...@google.com <nt...@google.com> #5
Hi Scott,
Thanks a lot for fixing this issue! Hope this issue gets resolved in the next release (by the final confirmation from the Pixel 3a user).
Regards, Mohit
ap...@google.com <ap...@google.com> #6
Is it possible to extend the list of devices that implement this workaround to include the Samsung A3 2017 (a3y17lte) please? There is an open issue reporting the same original issue as with the Pixel 3a (https://issuetracker.google.com/issues/235172945 ) but it doesn't seem to have received any traction as of yet.
Description
I was playing around with AssetLoader and I found that the order of builder arguments matters. I found this extremely surprising, and this is not the normal convention for builders. As an example, here are two pieces of Java code which do different things:
The issue is we dereference thehttps://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:webkit/webkit/src/main/java/androidx/webkit/WebViewAssetLoader.java;l=526;drc=764112d6d736023c63322b262bec9c93e67786ca
mDomain
whenaddPathHandler
is called, but we really should wait until.build()
is called. Same problem withmHttpAllowed
. See