Fixed
Status Update
No update yet.
Comments
an...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024
Expand native target support for annotation and collection libraries
- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection
This work is required as we work towards setting up native stubs for
compose projects.
Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018
M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
https://android-review.googlesource.com/3151736
Branch: androidx-main
commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024
Expand native target support for annotation and collection libraries
- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection
This work is required as we work towards setting up native stubs for
compose projects.
Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018
M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
Description
Version used: 1.4.2
Devices/Android versions reproduced on: Pixel 4
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).
Step to reproduce:
1) Import project from google3/experimental/users/ychr/java/dev/viewpager/
2) patch cl/362126372
3) build and deploy the app: a view pager with 5 pages
4) select "Gray" tab to go to gray page
The followings are in log
2021-03-10 12:03:06.532 30105-30105/dev.viewpager I/ViewPagerState: before rememberSaveable content.value.items.size 5
2021-03-10 12:03:06.532 30105-30105/dev.viewpager I/ViewPagerState: state dev.viewpager.render.ViewPagerState@19b483b current page 2
5) tap on "Delete this page" button to delete gray page --> view page switches to first tab(page) : blue page
The followings are in log
2021-03-10 12:03:30.345 30105-30105/dev.viewpager I/ViewPagerState: before rememberSaveable content.value.items.size 4
2021-03-10 12:03:30.345 30105-30105/dev.viewpager I/ViewPagerState: state dev.viewpager.render.ViewPagerState@5caf269 current page 0
6) rotate the screen, green page (page index 2) is displayed instead of blue page
The followings are in log
2021-03-10 12:03:36.849 30105-30105/dev.viewpager I/ViewPagerState: before rememberSaveable content.value.items.size 4
2021-03-10 12:03:36.850 30105-30105/dev.viewpager I/ViewPagerState: state dev.viewpager.render.ViewPagerState@2ab65be current page 2
Examing `rememberSaveable` source code,
If the `value` changes in
it won't trigger a re-save, because the sideeffect only runs when `registry` and `finalKey` changes
A fix like
will address the issue