swipeWithVelocity() is difficult to use [182477143]

Fixed

Bug

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Mar 11, 2021 05:55PM

I'm using swipeWithVelocity() to test a scrolling layout, but I've found it difficult to find the magic combination of distance, duration and velocity to make it work.

I consistently see the following error in tests:

java.lang.IllegalArgumentException: Creating a gesture between 295.2 and 424.80002 with a duration of 3000 and a resulting velocity of 2.0 results in a movement that goes outside of the range [295.2..424.80002]

While I can find some values which work for 1 device, it may not work for all devices, due to different sizes.

Comments

je...@google.com <je...@google.com> #2Mar 11, 2021 06:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ch...@gmail.com <ch...@gmail.com> #3Sep 10, 2021 03:20PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

je...@google.com <je...@google.com> #4Sep 13, 2021 05:11PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

je...@google.com <je...@google.com> #5Sep 14, 2021 09:29AM

On second thought, even though it is technically possible, I'm not sure if it makes sense to have this particular bit of API accept dp while all other methods accept positions in px. What I can do, however, is let TouchInjectionScope extend Density, so you can always easily convert between px and dp. I think in combination with a clear explanation in the docs that will give the cleanest API. What do you think?

ap...@google.com <ap...@google.com> #6Sep 14, 2021 04:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit ebf2e69f48e922f8abced7626b587bfc7745da01
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Sep 02 15:37:36 2021

Generate better swipes with velocity

This uses a new algorithm to derive a function for the path of the swipe
which results in much looser constraints. When a function can't be
created because the parameters are too strict, it will give suggestions
for adjustments in the parameters so that it becomes possible to
generate a swipe that ends with a given velocity.

Bug: 182477143
Test: ./gradlew compose:ui:ui-test:cC
Relnote: "Improved `TouchInjectionScope.swipeWithVelocity`. It now
accepts a wider range of input variables and will suggest changes to the
input if a swipe can't be created"

Change-Id: I40fbe57b6f28689bc2597b2e64ae0ef28158e593

M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/injectionscope/touch/SwipeWithVelocityTest.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/injectionscope/touch/VelocityPathFinderTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/util/Truth.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/TouchInjectionScope.kt
A compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/VelocityPathFinder.kt

https://android-review.googlesource.com/1823303

je...@google.com <je...@google.com> Sep 20, 2021 05:37PM

Marked as fixed.

Issue 182477143