constraintlayout-compose : upgrading from alpha03 to alpha 04 breaks an existing layout. [182657720]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Mar 14, 2021 02:13PM

ConstraintLayout version: androidx.constraintlayout:constraintlayout-compose:1.0.0-alpha04

Here is the screen composable, attached are screenshots when run with alpha03 (ok) and alpha04 (not okay).

@Composable
private fun Screen() {
    ConstraintLayout(
      modifier = Modifier
        .fillMaxSize()
    ) {
      val (image, header, tag1, tag2, tag3, bSignup, bLogin, disclaimer) = createRefs()
      val g1 = createGuidelineFromStart(44.dp)
      val g2 = createGuidelineFromEnd(44.dp)
      Image(
        modifier = Modifier.constrainAs(image) {
          width = Dimension.value(201.dp)
          height = Dimension.value(179.dp)
          top.linkTo(parent.top, 32.dp)
          start.linkTo(g1)
        },
        painter = painterResource(id = R.drawable.intercom_snooze),
        contentDescription = null
      )
      Text(
        modifier = Modifier.constrainAs(header) {
          top.linkTo(image.bottom, 32.dp)
          start.linkTo(g1)
          end.linkTo(g2)
          width = Dimension.fillToConstraints
        },
        text = stringResource(id = R.string.welcome_header),
        style = MaterialTheme.typography.h5,
      )
      Text(
        modifier = Modifier.constrainAs(tag1) {
          top.linkTo(header.bottom, 16.dp)
          start.linkTo(g1)
          end.linkTo(g2)
          width = Dimension.fillToConstraints
        },
        text = stringResource(id = R.string.welcome_tagline1)
      )
      Text(
        modifier = Modifier.constrainAs(tag2) {
          top.linkTo(tag1.bottom, 8.dp)
          start.linkTo(g1)
          end.linkTo(g2)
          width = Dimension.fillToConstraints
        },
        text = stringResource(id = R.string.welcome_tagline2)
      )
      Text(
        modifier = Modifier.constrainAs(tag3) {
          top.linkTo(tag2.bottom, 8.dp)
          start.linkTo(g1)
          end.linkTo(g2)
          width = Dimension.fillToConstraints
        },
        text = stringResource(id = R.string.welcome_tagline3)
      )
      Button(
        modifier = Modifier.constrainAs(bSignup) {
          bottom.linkTo(bLogin.top, 16.dp)
          start.linkTo(g1)
          end.linkTo(g2)
          width = Dimension.fillToConstraints
        },
        onClick = {}
      ) {
        Text(text = stringResource(id = R.string.sign_up))
      }
      Button(
        modifier = Modifier.constrainAs(bLogin) {
          bottom.linkTo(disclaimer.top, 16.dp)
          start.linkTo(g1)
          end.linkTo(g2)
          width = Dimension.fillToConstraints
        },
        onClick = {},
      ) {
        Text(text = stringResource(id = R.string.log_in))
      }
      Text(
        modifier = Modifier.constrainAs(disclaimer) {
          bottom.linkTo(parent.bottom, 8.dp)
          start.linkTo(g1)
          end.linkTo(g2)
          width = Dimension.fillToConstraints
        },
        text = stringResource(id = R.string.trial_disclaimer),
        style = MaterialTheme.typography.caption,
      )
    }
}

alpha03.png

113 KB

View

Download

alpha04.png

111 KB

View

Download

Comments

ni...@gmail.com <ni...@gmail.com> #2Mar 15, 2021 11:53PM

I simpler example would be appreciated. I tried to download the pull request and build it but it relies on, for example, `rustc` to be installed which I don't have installed on my compose development machine.

Does the program work without the compiler switch. That is, is `"-P", "plugin:androidx.compose.compiler.plugins.kotlin:experimentalStrongSkipping=true",` required to reproduce or is just changing the runtime enough?

ni...@google.com <ni...@google.com> #3Mar 15, 2021 11:56PM

Marked as fixed.

Yeah, changing compiler switch(enable/disable StrongSkipping, enable/disable nonSkippingGroup) has no effect, only changing runtime make sense.
Sorry for that, I will try to extract an example when I'm free.

di...@gmail.com <di...@gmail.com> #4Jul 29, 2021 02:47PM

I have find a sample code to reproduce that

        setContent {
            val dialogState = remember { DialogState() }
            dialogState.Intercept()
            LaunchedEffect(Unit) {
                delay(1000)
                dialogState.bgWork {
                    delay(5000)
                }
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }
            }
        }

You can find implementation of DialogState here https://github.com/FooIbar/EhViewer/blob/ef16bdeb755ae888c74eaa4a337bd5b708fcc97e/app/src/main/kotlin/com/hippo/ehviewer/ui/tools/Dialog.kt#L92
https://github.com/FooIbar/EhViewer/blob/main/app/src/main/kotlin/com/hippo/ehviewer/util/Progress.kt Launch that Activity, wait 6 seconds and it will crash

Issue 182657720

Description

Issue summary

Comments

ni...@gmail.com <ni...@gmail.com> #2Mar 15, 2021 11:53PM

ni...@google.com <ni...@google.com> #3Mar 15, 2021 11:56PM

di...@gmail.com <di...@gmail.com> #4Jul 29, 2021 02:47PM

Add comment

Issue metadata