Parity for PopupMenu.setForceShowIcon [182789798]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

al...@google.com

created issue #1

Mar 15, 2021 03:03PM

We should provide parity with the platform by providing setForceShowIcon on AppCompat's PopupMenu.

Comments

cr...@google.com <cr...@google.com> #2Mar 23, 2021 08:40PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

al...@google.com <al...@google.com> #3Mar 23, 2021 08:44PM

Great! Thanks a lot, I'll look for the live updates soon!

al...@google.com <al...@google.com> #4Mar 23, 2021 08:48PM

Adding to bug bounty list in case anyone wants to grab this.

Summary: Implement setForceShowIcon on AppCompat's popup menu (parity for platform source).

Sponsor: alanv@

Estimated workload: 2-5 days (depends on extent of backport required, since the feature may not be easy to support on earlier versions)

Technologies: Android platform, AppCompat

lo...@gmail.com <lo...@gmail.com> #5Mar 23, 2021 09:24PM

There's also RTL (right-to-left) layout direction to check.

al...@google.com <al...@google.com> May 26, 2021 07:09PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #6May 28, 2021 12:30AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f78191ddd630bda64823a86bf05278e9c519d103
Author: Alan Viverette <alanv@google.com>
Date: Wed May 26 15:15:09 2021

Expose setForceShowIcon as public API

Bumps appcompat version after build cut.

Relnote: "Add PopupMenu.setForceShowIcon for parity with platform APIs"
Fixes: 182789798
Test: N/A already exercised by ActionMenuPresented and StandardMenuPopup
Change-Id: I43bb3546cc529051e4b88e14438a9e77e8b1b177

M appcompat/appcompat/api/current.txt
M appcompat/appcompat/api/public_plus_experimental_current.txt
M appcompat/appcompat/api/restricted_current.txt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/PopupMenu.java
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt

https://android-review.googlesource.com/1719695

Issue 182789798