Transition with different sceneroot getting paused [182845041]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 16, 2021 12:30AM

Component used: androidx.transition
Version used: 1.4.0
Devices/Android versions reproduced on: all

If you do transitions on two sibling ViewGroups, A and B. A starts a transition on its root view, then B starts a transition. Inside of A's onTransitionEnd call back, if you start another transition on ViewGroup A, it will pause the Animators on the transition of ViewGroup B, which means the transition on B never ends.

Since two transitions with different sceneRoots should not interfere with one another, the expectation is that the transition on ViewGroup B does not get paused when by anything happening in ViewGroup A.

Not sure if this helps, but when starting another transition on ViewGroup A, the pause() in Transition makes a call to getRunningAnimators() here which returns the animator associated with ViewGroup B.

In the attached sample you can see that the transition run on the container view group never ends.

RootTransitionBug.zip

141 KB

Download

Comments

ya...@google.com <ya...@google.com> #2Mar 24, 2021 01:19AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

jb...@google.com <jb...@google.com> #3Mar 30, 2021 07:36PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ya...@google.com <ya...@google.com> #4Mar 31, 2021 07:21AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ya...@google.com <ya...@google.com> #5Mar 31, 2021 09:30AM

I still don't know what's causing the issue, but I found something interesting. There's a new FrameLayout added to the container at the end of the click listener. I don't know what it's for, but the issue does not reproduce if I comment out the line.

            container.addView(FrameLayout(this))

jb...@google.com <jb...@google.com> #6Mar 31, 2021 06:56PM

Without that does the container actually transition at all?

ap...@google.com <ap...@google.com> #7Apr 13, 2021 06:09AM

Project: platform/frameworks/support
Branch: androidx-main

commit 20516279db6bf59ecbee0ea05347f2d707fadd19
Author: Yuichi Araki <yaraki@google.com>
Date: Fri Apr 02 17:07:37 2021

Fix issue with multiple scene roots interfering each other

Use mCurrentAnimators instead of sRunningAnimators for pause and resume.

Using sRunningAnimators caused pause and resume to collect all the running animators from other
Transitions too.

Test: MultipleRootsTest
Bug: 182845041
Change-Id: I9a08a6181e0ae01303db5e2bcf188cfbdb0f7d65

A transition/transition/src/androidTest/java/androidx/transition/MultipleRootsTest.java
A transition/transition/src/androidTest/res/layout/multiple_roots.xml
M transition/transition/src/main/java/androidx/transition/Transition.java

https://android-review.googlesource.com/1664439

ya...@google.com <ya...@google.com> Apr 13, 2021 06:10AM

Marked as fixed.