Status Update
Comments
an...@jetbrains.com <an...@jetbrains.com>
ar...@google.com <ar...@google.com>
pe...@google.com <pe...@google.com>
du...@google.com <du...@google.com> #2
I am not sure I understand the use case. how can the benchmark be code to real world scenario when it's not possible to do right now ? which scenario is it ?
In any case, since this would be for benchmarking, this would clearly not be available through the public DSL. We should find a semi-private way of doing this (maybe the private variant API object could offer that functionality for instance or a property).
an...@jetbrains.com <an...@jetbrains.com> #3
We want benchmarks to measure code after Progaurd / R8, but it's not possible to turn that on for androidTests in library modules at the moment (to my knowledge?)
Benchmarks are also a public facing thing, but we have a plugin to help configure gradle builds for our users, so if support for this ends up in a private API, we could try to keep those usages localized to our code perhaps.
du...@google.com <du...@google.com> #4
Any update on the status of this request and when it can be supported?
Thanks,
Amanda
du...@google.com <du...@google.com> #5
this is not part of our OKR at this point so we are not talking soon. at first glance, we would need to simulate usage patterns to minify against and such, this seems substantial amount of work. there are not a lot of library module that have android tests, most only rely on unit-tests.
how important is this ? we are out of PM right now but I suspect the next step will be to negotiate with J. Eason and xav@ to scale a priority level.
an...@google.com <an...@google.com> #6
This is a high priority request for Compose, to enable their benchmarks to measure release accurate performance. (Micro) Benchmarks are library modules, as they don't need the complexity of multi-apk tests - they're self measuring APKs that depend on libraries. (d.android.com/benchmark)
there are not a lot of library module that have android tests, most only rely on unit-tests.
To clarify, this is for com.android.library
modules, not jars - I'd expect most of those to use android tests (all of the libraries in jetpack for example do).
we would need to simulate usage patterns to minify against and such, this seems substantial amount of work
Simulate usage patterns? I don't understand - the dev can themselves provide a keep rule for test infra / classes if necessary. Long term, keep rules should be provided by test libraries.
Description
Android Plugin 4.0, 4.1 in 2020.2, 2020.3, 2021.1. Earlier versions also affected.
Reported here:https://youtrack.jetbrains.com/issue/IDEA-244008 . See also IDEA-198719 and all its duplicates for different scenarios.
Steps
zip
file to the projectExpected
ZIP file is opened
Actual
Android plugin intercepts the open action, tries to open zip file and fails with the exception
Pre-discussed with @Yuriy Solodkyy. On one hand, there is no clean way to identify that Android SDK is not configured (because there are no dependencies
android.apkanalyzer>android.core
, and introducing them does not look right, so classesIdeSdks
andAndroidSdks
are not available in theApkEditorProvider
). On the other hand,ApkViewPanel
should not even try to invokeProjectSystemUtil.getProjectSystem(myProject)
for non-android project.It would also be nice if SDK management was moved out of
android.core
, so other IDEs (like Rider) could use it easily. At JB we have team capacity to implement this.