Fixed

Bug

Status Update

No update yet.

Description

an...@jetbrains.com

created issue #1

Mar 16, 2021 07:52PM

Android Plugin 4.0, 4.1 in 2020.2, 2020.3, 2021.1. Earlier versions also affected.

Reported here: https://youtrack.jetbrains.com/issue/IDEA-244008. See also IDEA-198719 and all its duplicates for different scenarios.

Steps

Open freshly installed IDEA version (Android SDK has never been configured in the IDEA before).
Create simple java-gradle project from "command line" template (attached for convenience)
Put any zip file to the project
Try to open it via double-click in IDEA project navigator.

Expected

ZIP file is opened

Actual

Android plugin intercepts the open action, tries to open zip file and fails with the exception

java.lang.IllegalStateException: Cannot locate latest build tools
	at com.android.tools.apk.analyzer.AaptInvoker.getPathToAapt(AaptInvoker.java:103)
	at com.android.tools.idea.projectsystem.gradle.GradleProjectSystem.getPathToAapt(GradleProjectSystem.kt:74)
	at com.android.tools.idea.apk.viewer.ApkViewPanel.<init>(ApkViewPanel.java:133)
	at com.android.tools.idea.apk.viewer.ApkEditor.refreshApk(ApkEditor.java:138)
	at com.android.tools.idea.apk.viewer.ApkEditor.<init>(ApkEditor.java:121)
	at com.android.tools.idea.apk.viewer.ApkEditorProvider.createEditor(ApkEditorProvider.java:47)
	at com.intellij.openapi.fileEditor.impl.FileEditorManagerImpl.openFileImpl4Edt(FileEditorManagerImpl.java:989)
	at com.intellij.openapi.fileEditor.impl.FileEditorManagerImpl.lambda$openFileImpl4$17(FileEditorManagerImpl.java:960)
        ...

Pre-discussed with @Yuriy Solodkyy. On one hand, there is no clean way to identify that Android SDK is not configured (because there are no dependencies android.apkanalyzer>android.core, and introducing them does not look right, so classes IdeSdks and AndroidSdks are not available in the ApkEditorProvider). On the other hand, ApkViewPanel should not even try to invoke ProjectSystemUtil.getProjectSystem(myProject) for non-android project.

It would also be nice if SDK management was moved out of android.core, so other IDEs (like Rider) could use it easily. At JB we have team capacity to implement this.

Comments

an...@jetbrains.com <an...@jetbrains.com> Mar 16, 2021 08:05PM

java-gradle-project.zip

59 KB

Download

ar...@google.com <ar...@google.com> Mar 16, 2021 08:55PM

Assigned to an...@google.com.

pe...@google.com <pe...@google.com> Dec 15, 2022 08:41PM

Status: New

du...@google.com <du...@google.com> #2Sep 13, 2024 04:57PM

Marked as fixed, reassigned to du...@google.com.

I don't think the average developer understands the distinction between method references and method definitions in this context (inside a DEX file). I know I don't.

@jvg, can you elaborate?

Message last modified on Sep 13, 2024 04:57PM

an...@jetbrains.com <an...@jetbrains.com> #3Sep 16, 2024 10:08AM

people who are looking at the bytecode in the dex to optimize their app through shrinking hopefully will learn the difference as string tables for method references between various dex files can account for quite a bit of disk space. but more importantly a definition is something you can analyze its code for where a reference you can't so the UI can be confusing without seeing the difference

du...@google.com <du...@google.com> #4Sep 16, 2024 06:04PM

Status: Assigned (reopened)

How about something like this?

I think having defined members be directly under the class node while references are nested in a group makes more sense.

Also note that the method refs have a slightly different icon. There is no existing equivalent for field refs that I could find.

https://screenshot.googleplex.com/4yXVM9Rzh4wnkjM.png

du...@google.com <du...@google.com> #5Sep 16, 2024 07:26PM

Marked as fixed.

sounds reasonable to me, thanks

an...@google.com <an...@google.com> #6Sep 23, 2024 08:03PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 4
Android Gradle Plugin 8.8.0-alpha04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

IssueTracker

Android Plugin in IDEA prevents IDEA from opening ZIP files

Status Update

Description

Steps

Expected

Actual

Comments

an...@jetbrains.com <an...@jetbrains.com> Mar 16, 2021 08:05PM

ar...@google.com <ar...@google.com> Mar 16, 2021 08:55PM

pe...@google.com <pe...@google.com> Dec 15, 2022 08:41PM

du...@google.com <du...@google.com> #2Sep 13, 2024 04:57PM

an...@jetbrains.com <an...@jetbrains.com> #3Sep 16, 2024 10:08AM

du...@google.com <du...@google.com> #4Sep 16, 2024 06:04PM

du...@google.com <du...@google.com> #5Sep 16, 2024 07:26PM

an...@google.com <an...@google.com> #6Sep 23, 2024 08:03PM

Issue 182906226

Description

Steps

Expected

Actual

Issue summary

Comments

an...@jetbrains.com <an...@jetbrains.com> Mar 16, 2021 08:05PM

ar...@google.com <ar...@google.com> Mar 16, 2021 08:55PM

pe...@google.com <pe...@google.com> Dec 15, 2022 08:41PM

du...@google.com <du...@google.com> #2Sep 13, 2024 04:57PM

an...@jetbrains.com <an...@jetbrains.com> #3Sep 16, 2024 10:08AM

du...@google.com <du...@google.com> #4Sep 16, 2024 06:04PM

du...@google.com <du...@google.com> #5Sep 16, 2024 07:26PM

an...@google.com <an...@google.com> #6Sep 23, 2024 08:03PM

Add comment

Issue metadata