Move from BottomNavigationView to NavigationBarView to support new NavigationRail component [182938895]

Fixed

Feature Request

Status Update

No update yet.

Description

ke...@google.com

created issue #1

Mar 16, 2021 09:49PM

With the release of NavigationRail in Material 1.4.O-alpha01, some of the navigation component methods should support the superclass NavigationBarView instead of BottomNavigationView

BottomNavigationView.setupWithNavController(navController: NavController) is an example of a method that needs to be updated.

Comments

il...@google.com <il...@google.com> Mar 16, 2021 09:50PM

Assigned to ke...@google.com.

ke...@google.com <ke...@google.com> #2Apr 12, 2021 11:44PM

Updated BottomNavigationView and NavigationBarView to allow us to use just NavigationBarViewfor this. Working on updating in Navigation now

ap...@google.com <ap...@google.com> #3May 13, 2021 08:39PM

Project: platform/prebuilts/androidx/external
Branch: androidx-main

commit baa8ebfdfb27ae57b936ae4d31ef6e93cf9173f5
Author: Kenneth Ford <kennethford@google.com>
Date: Tue May 11 20:22:40 2021

Adds the updated material android dependency

Bug: 182938895
Test: N/A
Change-Id: I86b16fae46ad2d19f3a4c04be578712d37fce4b3

A com/google/android/material/material/1.4.0-beta01/LICENSE
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01-sources.jar
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01-sources.jar.md5
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01-sources.jar.sha1
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.aar
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.aar.md5
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.aar.sha1
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.module
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.module.md5
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.module.sha1
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.pom
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.pom.md5
A com/google/android/material/material/1.4.0-beta01/material-1.4.0-beta01.pom.sha1

https://android-review.googlesource.com/1704185

ap...@google.com <ap...@google.com> #4May 13, 2021 08:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit e2e12de8907d96c2f20a54421e8004e11c36b352
Author: Kenneth Ford <kennethford@google.com>
Date: Tue May 11 19:33:53 2021

Moves from supporting BottomNavigation to the NavigationBarView super class
to better support adaptive layouts who use both BottomNav and NavigationRail
components

Relnote: "Changes to supporting superclass for better support of both BottomNav
and NavRail"
Bug: 182938895
Test: N/A

Change-Id: Ib0b36d933571daab2e94a79d524388c282a8c23c

M navigation/navigation-ui/api/current.ignore
M navigation/navigation-ui/api/current.txt
M navigation/navigation-ui/api/public_plus_experimental_current.txt
M navigation/navigation-ui/api/restricted_current.ignore
M navigation/navigation-ui/api/restricted_current.txt
M navigation/navigation-ui/build.gradle
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/BottomNavigationView.kt
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.kt

https://android-review.googlesource.com/1703753

ke...@google.com <ke...@google.com> May 13, 2021 09:16PM

Marked as fixed.

il...@google.com <il...@google.com> #5May 13, 2021 10:03PM

The BottomNavigationView.setupWithNavController(NavController) method (and the NavigationUI.setupWithNavController(BottomNavigationView, NavController) methods have been replaced with versions that use the more generic NavigationBarView class (which BottomNavigationView extends as of the Material Components 1.4.0-alpha01).

This means that the navigation-ui artifact will support any type of NavigationBarView as of the Navigation 2.4.0-alpha02 release. Note that this means that now has a transitive dependency on com.google.android.material:material:1.4.0-beta01.

Issue 182938895