Expose contentPadding parameter in all AppBar composables [183161866]

Fixed

Feature Request

Status Update

No update yet.

Description

ni...@google.com

created issue #1

Mar 19, 2021 07:35AM

It would be useful if all AppBar composables exposed the contentPadding parameter with a default value. An example use case is applying window insets to an AppBar (Modifier.padding doesn't work because it applies to the background as opposed to the inner content).

Currently it's only exposed by:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt;l=149

But it's not exposed by the below variation of TopAppBar, which uses AppBarDefaults.ContentPadding directly:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt;l=149

Please expose it as a parameter with a default value, eg.

@Composable
fun TopAppBar(
    ...
    contentPadding: PaddingValues = AppBarDefaults.ContentPadding
) {
    AppBar(
        ...
        contentPadding,
        ...
    ) {
        ...
    }
}

Comments

lp...@google.com <lp...@google.com> #2Mar 19, 2021 09:43AM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ni...@google.com <ni...@google.com> #3Mar 19, 2021 09:49AM

Thanks for the report!

lp...@google.com <lp...@google.com> #4Mar 19, 2021 09:51AM

Status: Won't Fix (Intended Behavior)

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

dy...@gmail.com <dy...@gmail.com> #5Jun 13, 2022 08:47AM

deleted

ap...@google.com <ap...@google.com> #6Aug 12, 2022 04:50AM

Marked as fixed.

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

Issue 183161866