Finish moving TextInputService.show|hide to @InternalTextAPI [183448615]

Assigned

Internal Cleanup

Status Update

No update yet.

Description

se...@google.com

created issue #1

Mar 23, 2021 12:35AM

TextInputService.show|hide keyboard functions were marked @Deprecated in preparation for their replacement with LocalSoftwareKeyboardController.

Complete the refactor and either:

Mark them @InternalTextApi or
Add a PlatformSoftwareKeyboardController and remove them

Comments

si...@google.com <si...@google.com> Apr 12, 2021 02:33PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #2Jul 18, 2022 06:08PM

Accepted by se...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3d00acd443e0e5dd2cc33eb314a65f78f21cec61
Author: Calin Tataru <calintat@google.com>
Date: Mon Aug 10 17:59:53 2020

Modifier.swipeable polishing

This CL does the following things:
* Expand the documentation in SwipeableState.
* Make the setter of SwipeableState.value private.
* Rename some of the properties in SwipeableState, and slightly change
the definition of swipeTarget (now called targetValue) so that it uses
the target value of the ongoing animation if isAnimationRunning = true.
* Add a rememberSwipeableState function to help reduce boilerplate.
* Add Savers for [Drawer/BottomDrawer/Dismiss/Swipeable]State, so that
we can use rememberSavedInstanceState in the rememberFooState functions.

Bug: 163129614
Bug: 163132293
Test: Ran SwipeableTest and other tests depending on swipeable
Relnote: "Renamed some properties in SwipeableState: swipeTarget ->
targetValue, swipeProgress -> progress, swipeDirection -> direction.
Added a rememberSwipeableState function for creating SwipeableStates."
Change-Id: I2fc9c3af465b579a18359ae0aa0853c2d2b02abe

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/SwipeToDismissSamples.kt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/SwipeableSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/SwipeableTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/SwipeToDismiss.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Swipeable.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Switch.kt

https://android-review.googlesource.com/1396349

se...@google.com <se...@google.com> #3Jul 18, 2022 06:09PM

Assigned to bu...@google.com.

I added a rememberSwipeableState function to easily create and remember a SwipeableState with the default animation clock. That should work perfectly for your usecase.

bu...@google.com <bu...@google.com> #4Jul 18, 2022 06:09PM

Accepted by bu...@google.com.

Regression in material3: the function is now marked internal. Please re-open.

ap...@google.com <ap...@google.com> #5Jul 26, 2022 03:29PM

https://cs.android.com/androidx/platform/frameworks/support/+/4e99cad7cfba400da47af86a08f68df6b40c6e51

bu...@google.com <bu...@google.com> #6Oct 5, 2022 07:01AM

Assigned to se...@google.com.

Thanks for your feedback. We are looking into the ways of improving the current Mosidifer.swipeable, it has a number of critical bugs and we don't want to publish it as-is in material3. Stay tuned

Issue 183448615