NavigationTemplate throws Exception on TravelEstimate.REMAINING_TIME_UNKNOWN [183632456]

Fixed

Bug

Status Update

No update yet.

Description

ra...@googlemail.com

created issue #1

Mar 25, 2021 09:55AM

Auto library version: "androidx.car.app:app:1.0.0-beta01"

When setting TravelEstimate.setReimingSeconds(TravelEstimate.REMAINING_TIME_UNKNOWN) and then calling NavigationTemplate.setDestinationTravelEstimate(travelEstimate) an Exeption is thrown:

 Caused by: java.lang.IllegalArgumentException: The destination travel estimate's remaining time must be greater or equal to zero
        at androidx.car.app.navigation.model.NavigationTemplate$Builder.setDestinationTravelEstimate(NavigationTemplate.java:217)
        at com.iternio.abrpapp.auto.screens.NavigationScreen.onGetTemplate(NavigationScreen.java:173)
        at androidx.car.app.Screen.getTemplateWrapper(Screen.java:340)
        at androidx.car.app.ScreenManager.getTopTemplate(ScreenManager.java:214)

The documentation of TravelEstimate.setRemainingTimeSeconds contains this:

public TravelEstimate.Builder setRemainingTimeSeconds(@IntRange(from = -1L) long remainingTimeSeconds)
Sets the estimated time remaining until arriving at the destination, in seconds.
If not set, REMAINING_TIME_UNKNOWN will be used.

If i manually set it to REMAINING_TIME_UNKNOWN i get the exception in NavigationTemplate.Builder.setDestinationTravelEstimate()

Which says:

Throws:
IllegalArgumentException – if the TravelEstimate's remaining time is less than zero

This is not consistent!

BR Samuel

Comments

sh...@google.com <sh...@google.com> #2Mar 25, 2021 04:10PM

Assigned to ja...@google.com.

You may create a LazyPagingItems through the extension Flow<PagingData>.collectAsLazyPagingItems()

To construct a Flow<PagingData> from static sample data for your preview, you can use PagingData.from(list)

ja...@google.com <ja...@google.com> #3Mar 25, 2021 04:37PM

The preview did compile, but no items displayed, other UI components such as Button works fine though.

The code now:

@Preview
@Composable
fun Preview() {
    val usersFlow = flowOf(
        PagingData.from(
            listOf(
                User("123", "33423", "2211", "Makanan", "Dapur", "Risal", "User", "Masakka")
            )
        )
    )

    DefaultTheme {
        Surface() {
            MainUi(
                users = usersFlow.collectAsLazyPagingItems(),
                onEditItem = {},
                onDeleteItem = {}
            ) {

            }
        }
    }
}

ra...@googlemail.com <ra...@googlemail.com> #4Mar 25, 2021 04:51PM

I don't know if this is related but the IDE give me this message

High number of internal exceptions has been detected. This indicates a serious problem with the IDE. Please consider clean reinstall of Android Studio. If the problem persists, please report a bug by following the link below.

Build: AI-203.7717.56.2031.7583922, 202107261959,

AI-203.7717.56.2031.7583922, JRE 11.0.10+0-b96-7249189x64 JetBrains s.r.o., OS Linux(amd64) v5.11.0-7620-generic, screens 1920.0x1080.0, 1920.0x1080.0

AS: Arctic Fox | 2020.3.1; Kotlin plugin: 203-1.5.21-release-328-AS7717.8; Android Gradle Plugin: 7.0.0; Gradle: 7.0.2; Gradle JDK: version 11.0.10; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

ja...@google.com <ja...@google.com> #5Mar 25, 2021 05:03PM

There is a possibility this will only work in the interactive mode, try to enable it:

https://developer.android.com/jetpack/compose/tooling#preview-interactive

The reason is the regular preview is displaying the first frame, however with LazyPagingItems there is always one frame with empty data and only then we load the real values

sh...@google.com <sh...@google.com> #6Mar 25, 2021 06:07PM

Nope, still the same.

ra...@googlemail.com <ra...@googlemail.com> #7Mar 25, 2021 06:16PM

In my project preview also doesn't works. I tried all suggestion above.

ap...@google.com <ap...@google.com> #8Mar 29, 2021 06:36PM

Same situation. Also does not works.

ja...@google.com <ja...@google.com> Mar 30, 2021 11:43PM

Marked as fixed.