Screen gets white patch and notification area blinks after returning to foreground from overview [183677215]

Assigned

Bug

Status Update

No update yet.

Description

te...@gmail.com

created issue #1

Mar 25, 2021 10:50AM

Device
OS Version: 8.1.0
Device model: Moto G (5S) Plus
Manufacturer: motorola
Available memory: 1733681152

http.agent: Dalvik/2.1.0 (Linux; U; Android 8.1.0; Moto G (5S) Plus Build/OPS28.65-36-14)

Screen gets white patch and notification area blinks after returning to foreground from overview

Steps to reproduce:
1. Using webview in hybrid application on android 8.1 OS, Motorola and Blackberry Motion b100-2 device
2. Notification area blink when opening keyboard
3. Application header gets hidden and remain functional, means the screen white at header area, but buttons at place even when header is hidden still functions properly

bugreport-sanders_n-OPS28.65-36-14-2021-03-24-08-48-29.zip

5.2 MB

Download

Comments

to...@google.com <to...@google.com> #2Apr 2, 2021 02:32PM

To work around this for our CHIPS tests, we had to use a java bridge and report what was available in javascript. But this doesn't fully cover http cookies which is an issue.

https://crrev.com/c/5250507

We should fix this when we implement this CookieManager API.

ab...@gmail.com <ab...@gmail.com> #3Apr 8, 2021 07:04AM

This issue was migrated from

crbug.com/chromium/1523964?no_tracker_redirect=1

[Monorail components added to Component Tags custom field.]

Moto G__5S__Plus 2021-03-10 18-27-41.mp4

32 MB

Download

ok...@google.com <ok...@google.com> #4Apr 8, 2021 09:07PM

Another issue is that shouldInterceptRequest does not include the cookie header which forces developers to query it at the time of requests. We should include this as well.

Because this will likely require a breaking change, I will first experiment with this behind a flag: https://crrev.com/c/5616051

Screenshot-no-notifications.png

327 KB

View

Download

Screenshot-notifications.png

348 KB

View

Download

ab...@gmail.com <ab...@gmail.com> #5Apr 9, 2021 01:44PM

Project: chromium/src
Branch: main

commit 041b6a3c262e0ee8656e42fa6aa9cf32362fa9f2
Author: Rupert Ben Wiser <bewise@chromium.org>
Date: Fri Jun 28 18:08:13 2024

webview: Add cookie headers to shouldInterceptRequest

The problem is that shouldInterceptRequest
gets fired before the net stack ultimately adds the
cookie header. This means that Android developers have to
separately query the cookie manager for headers but as we introduce
new changes to the cookie header, the CookieManager API
can't keep up.

The one issue with this approach is that we are of course
having to try replicate what the network stack would be doing.
In this case, I am matching the partitioning but there
could be other cookie behaviors we need to preserve.
We are somewhat forced to maintain this already for WebView's
restricted cookie manager so we can share the policy which lowers
the maintenance burden a bit.

We also discovered that Set-Cookie doesn't have an effect with
shouldInterceptRequest either for similar reasons.
The Set-Cookie header is not allowed to be persisted over the mojo
calls so we need to return that value to our URL Loader factory with a
simple callback.

Bug: 41496912
Change-Id: Iff5cc37ab0f678c59503cc9d69e3c05cd4ccdf4a
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5616051
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Commit-Queue: Rupert Wiser <bewise@chromium.org>
Auto-Submit: Rupert Wiser <bewise@chromium.org>
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/main@{#1321072}

M android_webview/browser/aw_content_browser_client.cc
M android_webview/browser/aw_cookie_access_policy.h
M android_webview/browser/network_service/aw_proxying_url_loader_factory.cc
M android_webview/browser/network_service/aw_proxying_url_loader_factory.h
M android_webview/common/aw_switches.cc
M android_webview/common/aw_switches.h
M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
M components/embedder_support/android/util/android_stream_reader_url_loader.cc
M components/embedder_support/android/util/android_stream_reader_url_loader.h

https://chromium-review.googlesource.com/5616051

ab...@gmail.com <ab...@gmail.com> #6Apr 9, 2021 02:12PM

Project: chromium/src
Branch: main
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6237015

[WV] Determine if partitioned cookies are not sent to apps.

Expand for full commit details

[WV] Determine if partitioned cookies are not sent to apps. 
 
This allows an investigation into how often partitioned cookies are not 
passed to apps. Using CookieManager::SiteHasCookieInOtherPartition, this 
indicates whether a site's cookies, with one partition key, also has the 
same cookies with a different cookie partition key. This will prove that 
there are cookies being omitted on a given site due to the partitioning. 
 
Co-Authors: bewise, avvall 
Bug: 41496912 
Change-Id: I3698788038afc16c23bb05f6e7f485394433fd07 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237015 
Reviewed-by: Peter Beverloo <peter@chromium.org> 
Reviewed-by: Elly FJ <ellyjones@chromium.org> 
Reviewed-by: Maks Orlovich <morlovich@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1417004}

Files:

M android_webview/browser/aw_feature_map.cc
M android_webview/browser/cookie_manager.cc
M android_webview/browser/cookie_manager.h
M android_webview/common/aw_features.cc
M android_webview/common/aw_features.h
M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
M services/network/cookie_manager.cc
M services/network/cookie_manager.h
M services/network/public/mojom/cookie_manager.mojom
M services/network/test/test_cookie_manager.h
M tools/metrics/histograms/metadata/android/histograms.xml

Hash: cbebd148e6898552bdd91af1c63c92b2de40beed
Date: Thu Feb 06 13:52:04 2025

ab...@gmail.com <ab...@gmail.com> #7Apr 9, 2021 02:18PM

Project: chromium/src
Branch: main
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6240130

[WV] Add test config for WebViewPartitionedCookiesExcluded

Expand for full commit details

[WV] Add test config for WebViewPartitionedCookiesExcluded 
 
This adds a JSON config entry for WebViewPartitionedCookiesExcluded so 
that A/B experimentation can occur for this feature. This flag was added 
in `[WV] Determine if partitioned cookies are not sent to apps. | 
https://chromium-review.googlesource.com/c/chromium/src/+/6237015`. 
 
Test: N/A 
Bug: 41496912 
Change-Id: I29c0a210364734675331a3bf180ee0b33b7c45cb 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6240130 
Reviewed-by: Ben Pastene <bpastene@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1417090}

Files:

M testing/variations/fieldtrial_testing_config.json

Hash: ad82f6bbd357a122ba932a0d3ec711551561616f
Date: Thu Feb 06 16:49:55 2025

highlight-all-webviews-AndroidSnapshot.png

169 KB

View

Download

ok...@google.com <ok...@google.com> #8Apr 9, 2021 06:20PM

CLs listed at #6 and #7 are included in Canary #135.0.7003.0+, please update the bug with canary result on Monday morning.

So we can review it for M134 (+mcirlanaru@ too)

ab...@gmail.com <ab...@gmail.com> #9Apr 10, 2021 02:54PM

FYI govind@: metrics (as added by CL listed at #6) verified successfully in Canary.

to...@google.com <to...@google.com> #10Apr 12, 2021 02:47PM

The NextAction date has arrived: 2025-02-10 To opt-out from this automation rule, please add Optout-Blintz-Nextaction-Alert to the "Chromium Labels" custom field.

bo...@google.com <bo...@google.com> #11Apr 12, 2021 08:09PM

M134 branch 6998 merge approved for both CLs listed at #6 and #7 per comment #9 and per offline chat with Miahi.

nt...@google.com <nt...@google.com> #12Apr 12, 2021 08:31PM

Project: chromium/src
Branch: refs/branch-heads/6998
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6249545

[M134] [WV] Determine if partitioned cookies are not sent to apps.

Expand for full commit details

[M134] [WV] Determine if partitioned cookies are not sent to apps. 
 
This allows an investigation into how often partitioned cookies are not 
passed to apps. Using CookieManager::SiteHasCookieInOtherPartition, this 
indicates whether a site's cookies, with one partition key, also has the 
same cookies with a different cookie partition key. This will prove that 
there are cookies being omitted on a given site due to the partitioning. 
 
(cherry picked from commit cbebd148e6898552bdd91af1c63c92b2de40beed) 
 
Co-Authors: bewise, avvall 
Bug: 41496912 
Change-Id: I3698788038afc16c23bb05f6e7f485394433fd07 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237015 
Reviewed-by: Peter Beverloo <peter@chromium.org> 
Reviewed-by: Elly FJ <ellyjones@chromium.org> 
Reviewed-by: Maks Orlovich <morlovich@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Original-Commit-Position: refs/heads/main@{#1417004} 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249545 
Reviewed-by: Nate Fischer <ntfschr@chromium.org> 
Commit-Queue: Krishna Govind <govind@chromium.org> 
Owners-Override: Krishna Govind <govind@chromium.org> 
Reviewed-by: Krishna Govind <govind@chromium.org> 
Cr-Commit-Position: refs/branch-heads/6998@{#387} 
Cr-Branched-From: de9c6fafd8ae5c6ea0438764076ca7d04a0b165d-refs/heads/main@{#1415337}

Files:

M android_webview/browser/aw_feature_map.cc
M android_webview/browser/cookie_manager.cc
M android_webview/browser/cookie_manager.h
M android_webview/common/aw_features.cc
M android_webview/common/aw_features.h
M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
M services/network/cookie_manager.cc
M services/network/cookie_manager.h
M services/network/public/mojom/cookie_manager.mojom
M services/network/test/test_cookie_manager.h
M tools/metrics/histograms/metadata/android/histograms.xml

Hash: 16aba54fcf062cfe3784b35d0230330f6e4dc3ba
Date: Mon Feb 10 10:17:21 2025

to...@google.com <to...@google.com> #13Apr 26, 2021 04:37PM

Project: chromium/src
Branch: refs/branch-heads/6998
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6249204

[M134] [WV] Add test config for WebViewPartitionedCookiesExcluded

Expand for full commit details

[M134] [WV] Add test config for WebViewPartitionedCookiesExcluded 
 
This adds a JSON config entry for WebViewPartitionedCookiesExcluded so 
that A/B experimentation can occur for this feature. This flag was added 
in `[WV] Determine if partitioned cookies are not sent to apps. | 
https://chromium-review.googlesource.com/c/chromium/src/+/6237015`. 
 
(cherry picked from commit ad82f6bbd357a122ba932a0d3ec711551561616f) 
 
Test: N/A 
Bug: 41496912 
Change-Id: I29c0a210364734675331a3bf180ee0b33b7c45cb 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6240130 
Reviewed-by: Ben Pastene <bpastene@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Original-Commit-Position: refs/heads/main@{#1417090} 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249204 
Reviewed-by: Krishna Govind <govind@chromium.org> 
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> 
Reviewed-by: Nate Fischer <ntfschr@chromium.org> 
Owners-Override: Krishna Govind <govind@chromium.org> 
Commit-Queue: Krishna Govind <govind@chromium.org> 
Cr-Commit-Position: refs/branch-heads/6998@{#397} 
Cr-Branched-From: de9c6fafd8ae5c6ea0438764076ca7d04a0b165d-refs/heads/main@{#1415337}

Files:

M testing/variations/fieldtrial_testing_config.json

Hash: 3c33baad1d076a7fbf7a9c490cc4755f3bcc0bf5
Date: Mon Feb 10 11:52:17 2025

nt...@google.com <nt...@google.com> #14May 10, 2021 10:37PM

Friendly ping for the reporter: can you try setting the background color with https://developer.android.com/reference/android/webkit/WebView#setBackgroundColor(int) (ex. maybe changing this to a red background) to see if the top bar changes from white to red? This would help us confirm if WebView really is the problem.

Since you have WebView DevTools, you could also try toggling the VizForWebView flag (or some of the other graphics flags) to see if this makes the bug go away. This would be very helpful for pinning down where the bug is in the code so we can fix it.

nt...@google.com <nt...@google.com> #15May 13, 2021 11:50PM

Status: Won't Fix (Not Reproducible)

I'm going to close this because it's been over a month since we've heard from the bugreporter. Please feel free to comment on this issue if you can experiment with that WebView API and our team will gladly reopen this to investigate further.

ab...@gmail.com <ab...@gmail.com> #16May 15, 2021 06:35AM

Hi Team,

I was sick due to covid therefore was not able to reply to your queries. Please give me sometime and will reply to your queries.

Thanks,
Abhiraj

to...@google.com <to...@google.com> #17May 17, 2021 03:15PM

Very sorry to hear that! Once you've had a chance to try some of the suggestions above and report back we'll reopen this to investigate further.

ab...@gmail.com <ab...@gmail.com> #18May 25, 2021 04:01AM

Hi Team,

(Copied from above comments - May 11)

Since you have WebView DevTools, you could also try toggling the VizForWebView flag (or some of the other graphics flags) to see if this makes the bug go away. This would be very helpful for pinning down where the bug is in the code so we can fix it.

I tried searching for "VizForWebView" flag in webview devtools but didn't find it. Could you please help in finding so that I can try to reproduce the issue and share the feedback with you all.

Thanks,

ab...@gmail.com <ab...@gmail.com> #19May 25, 2021 04:46AM

Hi Team,

I made some changes in webview dev tools to capture change in UI of Android Client. The images of both client and webview enabled flags is attached.

See if it helps in identifying the issue otherwise as mentioned in my previous comments, let me know "VizForWebView" flag in webview devtools and will try to reproduce the issue again.

Thanks

AndroidClientImage.png

156 KB

View

Download

WebViewFlags-Enabled.png

217 KB

View

Download

to...@google.com <to...@google.com> #20May 27, 2021 09:13PM

Status: Assigned (reopened)

VizForWebView has launched so the flag was removed in 92.0.4490.0; if you're on an older version it should be there; the description is just "Enables Viz for WebView."

It looks like the bars did *not* change color when you set the background, which suggests this is not just rendering the WebView in those regions and it may be a more general issue with the UI. :(

to...@google.com <to...@google.com> #21May 27, 2021 09:13PM

Bo, is there anything else that can be done here to investigate?

ab...@gmail.com <ab...@gmail.com> #22Jul 27, 2021 11:32AM

Any further update or anything required from our side on this.

Thanks,
Abhiraj

ab...@gmail.com <ab...@gmail.com> #23Aug 18, 2021 10:17AM

Hi Team,

Could you please share an update on this bug.

Thanks,
Abhiraj

ab...@gmail.com <ab...@gmail.com> #24Mar 4, 2022 03:07AM

Hi Team,

Could you please share an update on this bug.

Thanks,
Abhiraj

ab...@gmail.com <ab...@gmail.com> #25Mar 28, 2022 09:57AM

Hi Team,

Could you please share an update on this bug.

Thanks,
Abhiraj

IssueTracker