Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
an...@google.com <an...@google.com> #2
Thanks for filing. Note for myself: potentially a duplicate of
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 6f0b4cb9ba77f6b8802c5d4616092e32e65a9a46
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Tue Mar 30 21:40:19 2021
Fix for changing the isPlaced state not causing redraw
This was affecting LazyColumn scrolling where in some cases the item which was visible in the previous frame and is not visible anymore as was not placed was still displayed.
Fixes: 183877420
Test: covered with tests both on LazyColumn and LayoutNode layer
Relnote: Fixed the issue when items of LazyColumn/LazyRow located on the edges were incorrectly positioned after fast fling
Change-Id: Ie4d13def7dc4b12d4f52b4c5edbb0abb5150f698
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/InvalidatingNotPlacedChildTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
https://android-review.googlesource.com/1659119
Branch: androidx-main
commit 6f0b4cb9ba77f6b8802c5d4616092e32e65a9a46
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Tue Mar 30 21:40:19 2021
Fix for changing the isPlaced state not causing redraw
This was affecting LazyColumn scrolling where in some cases the item which was visible in the previous frame and is not visible anymore as was not placed was still displayed.
Fixes: 183877420
Test: covered with tests both on LazyColumn and LayoutNode layer
Relnote: Fixed the issue when items of LazyColumn/LazyRow located on the edges were incorrectly positioned after fast fling
Change-Id: Ie4d13def7dc4b12d4f52b4c5edbb0abb5150f698
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazyColumnTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/InvalidatingNotPlacedChildTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
Description
Jetpack Compose release version: 1.0.0-beta03
Steps to Reproduce:
Sometimes, when scroll stops, topmost Text composable lays out wrong, resulting in visual artefact, but snaps into place after new scroll. Example in attached video