popEnterAnim doesn't play [183877426]

Fixed

Bug

Status Update

No update yet.

Description

si...@outlook.com

created issue #1

Mar 29, 2021 10:24AM

Component used: Fragment
Version used: 1.3.2
Devices/Android versions reproduced on:

both
findNavController().navigate(
R.id.terms_catalog_fragment,
null,
navOptions {
anim {
enter = R.anim.slide_in_from_right
exit = R.anim.slide_out_to_left
popEnter = R.anim.slide_in_from_left
popExit = R.anim.slide_out_to_right
}
}
)

findNavController().navigate(
AboutFragmentDirections
.actionAboutFragmentToTermsCatalogFragment()
)

doesn't play popEnterAnim. I use android.R.animator.fade_in and android.R.animator.fade_out, still doesn't play popEnterAnim.

I didn't use any custom navOption. just follow the official guide.

navigation component: 2.3.4

AVD Pixel 4 XL API 29 / Samsung s9+ API 29

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Comments

si...@outlook.com <si...@outlook.com> #2Mar 29, 2021 10:46AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

il...@google.com <il...@google.com> #3Mar 29, 2021 04:13PM

Please include a sample project that reproduces your issue.

As per the Fragment 1.3.2 release notes, it is expected that when you navigate(), the enter and exit animations run.

si...@outlook.com <si...@outlook.com> #4Mar 30, 2021 02:11AM

Thanks, here it's the project and video.

PopEnterAnimBug.zip

23 MB

Download

F1.3.2_N2.3.4_bug 2021-03-30.mov

1.4 MB

Download

F1.3.0_N2.3.3_fixed 2021-03-30.mov

1.4 MB

Download

pr...@gmail.com <pr...@gmail.com> #5Mar 30, 2021 09:58AM

I am also facing same issue exit animations does not work even if i set it from navigation graph and using Direction Classes

il...@google.com <il...@google.com> Mar 31, 2021 11:17PM

Assigned to jb...@google.com.

mu...@gmail.com <mu...@gmail.com> #6Apr 1, 2021 03:00AM

I also saw the same issue. I suspect two modules are involved.
If either of them is versioned up, the same issue occurs.

My Check Point
androidx.appcompat.appcompat:1.3.0-beta01 -> rc01
fragment-ktx:1.3.1 -> 1.3.2

appcompat:1.3.0-beta01 & fragment-ktx:1.3.1 ----> not issue
appcompat:1.3.0-beta01 & fragment-ktx:1.3.2 ----> issue
appcompat:1.3.0-rc01 & fragment-ktx:1.3.1 ----> issue
appcompat:1.3.0-rc01 & fragment-ktx:1.3.2 ----> issue

I apologize for the immature comment. check please :)

cu...@gmail.com <cu...@gmail.com> #7Apr 1, 2021 04:00AM

I have the same issue:
When updating from androidx.appcompat.appcompat:1.3.0-beta01 to -rc01 or from fragment-ktx:1.3.1 to 1.3.2 popEnterAmin stops working.

[Deleted User] <[Deleted User]> #8Apr 3, 2021 02:28PM

Same issue, reverting to version 1.3.1 of androidx.fragment:fragment-ktx fixes the problem

ap...@google.com <ap...@google.com> #9Apr 8, 2021 11:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7a15383997e42b427798e2208cad5cbcce607c59
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Apr 08 15:25:28 2021

Fix popEnter animations when popping setPrimaryNavFragment

When doing a FragmentTransactions, if you setCustomAnimations with a
popEnter animation, do an op that triggers an animation (i.e. add, replace, etc),
and then do setPrimaryNavFragment, when you pop that transaction, there will be
no popEnter animation. The reason for this is the setPrimaryNavFragment
Op clears all of the animations for the incoming fragment.

We should only change animations for operations that actually trigger
them.

RelNote: "PopEnter animations will now be present when popping a
setPrimaryNavFragment operation."
Test: FragmentAnimationTest
Bug: 183877426

Change-Id: I38c877ae34c825b3a451ab325b6f683de00a2457

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimationTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java

https://android-review.googlesource.com/1670154

vy...@gmail.com <vy...@gmail.com> #10Apr 9, 2021 06:32AM

I've created this issue, which is probably related:
https://issuetracker.google.com/issues/184856844

jb...@google.com <jb...@google.com> #11Apr 9, 2021 04:51PM

Marked as fixed.

This has been fixed internally and will be available as part of the Fragment version 1.3.3 release.

Issue 183877426

Description

Issue summary

Comments

si...@outlook.com <si...@outlook.com> #2Mar 29, 2021 10:46AM

il...@google.com <il...@google.com> #3Mar 29, 2021 04:13PM

si...@outlook.com <si...@outlook.com> #4Mar 30, 2021 02:11AM

pr...@gmail.com <pr...@gmail.com> #5Mar 30, 2021 09:58AM

il...@google.com <il...@google.com> Mar 31, 2021 11:17PM

mu...@gmail.com <mu...@gmail.com> #6Apr 1, 2021 03:00AM

cu...@gmail.com <cu...@gmail.com> #7Apr 1, 2021 04:00AM

[Deleted User] <[Deleted User]> #8Apr 3, 2021 02:28PM

ap...@google.com <ap...@google.com> #9Apr 8, 2021 11:48PM

vy...@gmail.com <vy...@gmail.com> #10Apr 9, 2021 06:32AM

jb...@google.com <jb...@google.com> #11Apr 9, 2021 04:51PM

Add comment

Issue metadata