Fixed
Status Update
Comments
si...@google.com <si...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 91ea279ff99d2ade8998596eb34254c472df8baf
Author: Siyamed Sinir <siyamed@google.com>
Date: Mon Mar 29 21:05:25 2021
RecordingInputConnection.sendKeyEvent
Since hardware keyboard on view/composable level
is added, we do not need to handle sendKeyEvent.
Test: Manual test on Pixel 4, Android 11, GBoard
Test: Manual test on Samsung S8, Android 9, Samsung keyboard
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
Test: ./gradlew compose:ui:ui:test
Test: ./gradlew compose:ui:ui:connectedAndroidTest
Bug: 184003208
Bug: 139322105
Change-Id: I68c6369a046c8e66b6945afa7679d2166eb9e08a
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/RecordingInputConnectionTest.kt
A compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/InputEventCallback2.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/RecordingInputConnection.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroid.android.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/input/RecordingInputConnectionUpdateTextFieldValueTest.kt
https://android-review.googlesource.com/1657169
Branch: androidx-main
commit 91ea279ff99d2ade8998596eb34254c472df8baf
Author: Siyamed Sinir <siyamed@google.com>
Date: Mon Mar 29 21:05:25 2021
RecordingInputConnection.sendKeyEvent
Since hardware keyboard on view/composable level
is added, we do not need to handle sendKeyEvent.
Test: Manual test on Pixel 4, Android 11, GBoard
Test: Manual test on Samsung S8, Android 9, Samsung keyboard
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
Test: ./gradlew compose:ui:ui:test
Test: ./gradlew compose:ui:ui:connectedAndroidTest
Bug: 184003208
Bug: 139322105
Change-Id: I68c6369a046c8e66b6945afa7679d2166eb9e08a
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/RecordingInputConnectionTest.kt
A compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/InputEventCallback2.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/RecordingInputConnection.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroid.android.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/input/RecordingInputConnectionUpdateTextFieldValueTest.kt
si...@google.com <si...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 2a814d0c81e2cee222eecf76d581dca2df6ddb15
Author: Siyamed Sinir <siyamed@google.com>
Date: Mon Apr 12 10:32:48 2021
Remove InputEventCallback from public API
The interface is not being used in any public
APIs. It is not possible to create an instance
and pass to a public API.
Initially it was used by hidden Android specific
classes, and now those classes use InputEventCallback2
since the interface does not have to be public.
RelNote: "InputEventCallback interface is deprecated.
It was not possible to use the interface in any
public API; and there was no usage of it in the
code."
Test: ./gradlew compose:ui:ui:test
Test: ./gradlew compose:ui:ui:connectedAndroidTest
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
Bug: 184003208
Change-Id: I34a0208fac88f99da33ce9c700a803454dfb27c7
M compose/ui/ui-text/api/1.0.0-beta05.txt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta05.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_1.0.0-beta05.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/InputEventCallback.kt
https://android-review.googlesource.com/1657170
Branch: androidx-main
commit 2a814d0c81e2cee222eecf76d581dca2df6ddb15
Author: Siyamed Sinir <siyamed@google.com>
Date: Mon Apr 12 10:32:48 2021
Remove InputEventCallback from public API
The interface is not being used in any public
APIs. It is not possible to create an instance
and pass to a public API.
Initially it was used by hidden Android specific
classes, and now those classes use InputEventCallback2
since the interface does not have to be public.
RelNote: "InputEventCallback interface is deprecated.
It was not possible to use the interface in any
public API; and there was no usage of it in the
code."
Test: ./gradlew compose:ui:ui:test
Test: ./gradlew compose:ui:ui:connectedAndroidTest
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
Bug: 184003208
Change-Id: I34a0208fac88f99da33ce9c700a803454dfb27c7
M compose/ui/ui-text/api/1.0.0-beta05.txt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta05.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_1.0.0-beta05.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/InputEventCallback.kt
Description
Since hardware keyboard on view/composable level is added, we do not need to handle sendKeyEvent.
Should change according to the implementation in BaseInputConnection.