`BoxWithConstraints` update lag [184173932]

Fixed

Bug

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Apr 1, 2021 09:22AM

Jetpack Compose release version:

Desktop: 0.4.0-build178
Android: [unknown] (Wasn't by myself but will be added if known)

Description: The content inside a BoxWithConstraints will not be updated immediately when changing the Theme between light and dark.

Steps to Reproduce:

Code for reproduction:

var isDarkTheme by remember { mutableStateOf(true) }

MaterialTheme(if(isDarkTheme) darkColors() else lightColors()) {
    Column(Modifier.fillMaxSize().background(MaterialTheme.colors.background)) {
        Button(onClick = { isDarkTheme = !isDarkTheme }) { Text("Toggle") }
        Box(Modifier.fillMaxWidth().fillMaxHeight(0.5f).background(MaterialTheme.colors.background))
        BoxWithConstraints(Modifier.fillMaxSize()) {
            Box(Modifier.fillMaxSize().background(MaterialTheme.colors.background))
        }
    }
}

Clicking the "Toggle" button (easier visible if clicked rapidly)

Comments

ma...@google.com <ma...@google.com> Apr 1, 2021 10:52AM

Assigned to an...@google.com.

th...@gmail.com <th...@gmail.com> #2Apr 1, 2021 01:49PM

This is similar to this bug report as well: https://issuetracker.google.com/issues/172590946

Message last modified on Apr 1, 2021 01:50PM

an...@google.com <an...@google.com> #3May 11, 2021 02:17PM

Reassigned to ch...@google.com.

Hi Yinglei, re-assigning back to you as you're currently working on exactly this for Snackbars.

ch...@google.com <ch...@google.com> #4May 11, 2021 10:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit 506fcdecc2dc257b58c574006d70ea9ce6f0bfda
Author: Yinglei Wang <yingleiw@google.com>
Date: Fri Feb 26 15:58:00 2021

add semantics liveRegion and apply it to snackbar

Snackbar should be marked as live region for accessibility. When talkback
is on, the snackbar is announced when it appears. Also added dismiss
action for the snackbar.

Note that since we are not merging up the tree for subtree change
events, we don't need to do extra work for live region. From android
documentation and discussion with Phil, the throttling delay is fine for
accessibility events from live region.

Relnote: "LiveRegion accessibility API is added.
If node is marked as a live region, the accessibility services
will automatically notify the user about its changes"

Fix:

b/153644625

b/172590946

b/182834687

Test: tested manully with talkback on. Unit tests added.

Change-Id: Idcf6f425b12b005e59ad77fe7430e466132ea87c

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SnackbarHostTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SnackbarHost.kt
M compose/ui/ui/api/1.0.0-beta04.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta04.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta04.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidComposeViewAccessibilityDelegateCompatTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/1580798

ap...@google.com <ap...@google.com> #5May 13, 2021 10:53PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit de27354b08213ee30616d35b2f894527125cd28a
Author: Chuck Jazdzewski <chuckj@google.com>
Date: Wed May 12 10:37:30 2021

Recompose late arriving changes immediately

If a composition changes a value observed by another composition
then the propagation of the change can be delayed by a frame. This
can cause noticible flicker as seen in

b/184173932

.

This change recomposes affected compositions immediately instead.

Relnote: """ControlledComposition API change to enable recomposing
changes in a recompose single pass."""

Fixes:

b/184173932

Test: ./gradlew :compose:r:r:tDUT
Change-Id: Iaafd1d5f11e2ee2b499745b9f111f7442563a4ce

M compose/runtime/runtime/api/1.0.0-beta08.txt
M compose/runtime/runtime/api/current.ignore
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_1.0.0-beta08.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_1.0.0-beta08.txt
M compose/runtime/runtime/api/restricted_current.ignore
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composition.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Recomposer.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/collection/IdentityArraySet.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/collection/IdentityScopeMap.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/CompositionTests.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/collection/IdentityArraySetTest.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/collection/IdentityScopeMapTest.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/mock/CompositionTest.kt

https://android-review.googlesource.com/1705446

Issue 184173932