`BoxWithConstraints` update lag [184173932]

Fixed

Bug

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Apr 1, 2021 09:22AM

Jetpack Compose release version:

Desktop: 0.4.0-build178
Android: [unknown] (Wasn't by myself but will be added if known)

Description: The content inside a BoxWithConstraints will not be updated immediately when changing the Theme between light and dark.

Steps to Reproduce:

Code for reproduction:

var isDarkTheme by remember { mutableStateOf(true) }

MaterialTheme(if(isDarkTheme) darkColors() else lightColors()) {
    Column(Modifier.fillMaxSize().background(MaterialTheme.colors.background)) {
        Button(onClick = { isDarkTheme = !isDarkTheme }) { Text("Toggle") }
        Box(Modifier.fillMaxWidth().fillMaxHeight(0.5f).background(MaterialTheme.colors.background))
        BoxWithConstraints(Modifier.fillMaxSize()) {
            Box(Modifier.fillMaxSize().background(MaterialTheme.colors.background))
        }
    }
}

Clicking the "Toggle" button (easier visible if clicked rapidly)

Comments

ma...@google.com <ma...@google.com> Apr 1, 2021 10:52AM

Assigned to an...@google.com.

th...@gmail.com <th...@gmail.com> #2Apr 1, 2021 01:49PM

Android 5.0, 5.1: it shows context menu at top of screen, not as popup. See screenshots.

Android framework doesn't support floating toolbar before 23. So this is intended behavior.

The crash information suggests that this is an error from Snapshot. chuckj@ can you please take a look? I don't know what exactly caused the readError in Snapshot, any suggestions? Thanks a lot!

Message last modified on Apr 1, 2021 01:50PM

an...@google.com <an...@google.com> #3May 11, 2021 02:17PM

Reassigned to ch...@google.com.

This looks like another instance of 193006595 which I am looking at now.

ch...@google.com <ch...@google.com> #4May 11, 2021 10:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit beeb84e7be604088ad40e080a8d0adb1bacbf695
Author: Chuck Jazdzewski <chuckj@google.com>
Date: Thu Jul 08 10:04:28 2021

Remove updating the transparent snapshot

A transparent snapshot is create for the block exeucted by
`Snapshot.observe()` which registers read and write observers
but without creating a snapshot. The code to advance the
global snapshot, however, created a new transparent snapshot in
an attempt to update it to the new global snapshot it just
created. This is not necessary, however, as the transparent
snapshot will retrieve the current global snapshot from
`currentGlobalSnapshot` instead of `previousSnapshot` if
`previousSnapshot` is `null`. With the previous code, if the
global snapshot is advanced by applying a new snapshot the
"updated" transparent snapshot will be left referring to an
older snapshot instead of the most recent global snapshot.
Any snapshot object created in the newly applied snapshot
will throw an exception when it is accessed, as reported in
the bugs. The solution is to remove the apparent vetiagal code.

Test: ./gradlew :compose:r:r:tDUT
Fixes:

b/193006595

b/192570897

Change-Id: I2c0d0b8f57bf70e5a98ea36ed141d97142a5e53e

M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/snapshots/Snapshot.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/snapshots/SnapshotTests.kt

https://android-review.googlesource.com/1760301

ap...@google.com <ap...@google.com> #5May 13, 2021 10:53PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit de27354b08213ee30616d35b2f894527125cd28a
Author: Chuck Jazdzewski <chuckj@google.com>
Date: Wed May 12 10:37:30 2021

Recompose late arriving changes immediately

If a composition changes a value observed by another composition
then the propagation of the change can be delayed by a frame. This
can cause noticible flicker as seen in

b/184173932

.

This change recomposes affected compositions immediately instead.

Relnote: """ControlledComposition API change to enable recomposing
changes in a recompose single pass."""

Fixes:

b/184173932

Test: ./gradlew :compose:r:r:tDUT
Change-Id: Iaafd1d5f11e2ee2b499745b9f111f7442563a4ce

M compose/runtime/runtime/api/1.0.0-beta08.txt
M compose/runtime/runtime/api/current.ignore
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_1.0.0-beta08.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_1.0.0-beta08.txt
M compose/runtime/runtime/api/restricted_current.ignore
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composition.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Recomposer.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/collection/IdentityArraySet.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/collection/IdentityScopeMap.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/CompositionTests.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/collection/IdentityArraySetTest.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/collection/IdentityScopeMapTest.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/mock/CompositionTest.kt

https://android-review.googlesource.com/1705446

Issue 184173932