`BoxWithConstraints` update lag [184173932]

Fixed

Bug

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Apr 1, 2021 09:22AM

Jetpack Compose release version:

Desktop: 0.4.0-build178
Android: [unknown] (Wasn't by myself but will be added if known)

Description: The content inside a BoxWithConstraints will not be updated immediately when changing the Theme between light and dark.

Steps to Reproduce:

Code for reproduction:

var isDarkTheme by remember { mutableStateOf(true) }

MaterialTheme(if(isDarkTheme) darkColors() else lightColors()) {
    Column(Modifier.fillMaxSize().background(MaterialTheme.colors.background)) {
        Button(onClick = { isDarkTheme = !isDarkTheme }) { Text("Toggle") }
        Box(Modifier.fillMaxWidth().fillMaxHeight(0.5f).background(MaterialTheme.colors.background))
        BoxWithConstraints(Modifier.fillMaxSize()) {
            Box(Modifier.fillMaxSize().background(MaterialTheme.colors.background))
        }
    }
}

Clicking the "Toggle" button (easier visible if clicked rapidly)

Comments

ma...@google.com <ma...@google.com> Apr 1, 2021 10:52AM

Assigned to an...@google.com.

th...@gmail.com <th...@gmail.com> #2Apr 1, 2021 01:49PM

Is this really a P1? This seems less priority than the perf work that I am doing but if it is a P1 I will block that and work on this.

Message last modified on Apr 1, 2021 01:50PM

an...@google.com <an...@google.com> #3May 11, 2021 02:17PM

Reassigned to ch...@google.com.

I'm happy to move it to a p2, but it seems like a pretty big correctness issue that we should take a look at in the near future. I'm also happy to help look at this myself if you can give me some pointers on what the issue may be

ch...@google.com <ch...@google.com> #4May 11, 2021 10:31PM

This is not simple as and will change once Jim lands the threading of the composer.

ap...@google.com <ap...@google.com> #5May 13, 2021 10:53PM

Marked as fixed.

Sure thing, thanks for the context!

For anyone running into this issue, in the meantime the simple workaround is just consuming the ambient inside the body of the function, you don't explicitly need to use the returned value anywhere.

Issue 184173932