Merge navigation-ktx extensions into the main library [184292145]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Apr 1, 2021 09:46PM

Merge navigation-ktx extensions into the main library. In particular this will help avoid having duplicate file names such as androidx/navigation/NavGraph.kt

Comments

il...@google.com <il...@google.com> Apr 1, 2021 09:58PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Apr 5, 2021 06:32PM

Oh I forgot to mention that I thought it might be connected to this issue: https://issuetracker.google.com/issues/243778589. But after trying 2.5.2 I can say that the issue persists.

ap...@google.com <ap...@google.com> #3Apr 5, 2021 09:24PM

Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.

ap...@google.com <ap...@google.com> #4Apr 5, 2021 09:49PM

Sorry for the delay. I got a working example here: https://github.com/Del-S/issues. The project is set up to crash when navigating to ThirdFragment (nested nav graph) with poping the graph.

I poked into it a little bit and it seems to be connected to SafeArgs gradle plugin. When safe args is used to navigate to ThirdFragment (with nested graph poped) it will try to recreate te parent but there were no arguments passed so it crashes.

Steps to reproduce:

Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
Navigate to Third fragment using SafeArgs and the app crashes.

Crash log:

Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)

Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here: https://github.com/Del-S/issues/blob/master/app/src/main/java/cz/dels/issues/SecondFragment.kt#L37.

ap...@google.com <ap...@google.com> #5Apr 5, 2021 09:51PM

Ups a typo: Navigate from ~~Second~~ First Fragment to Child nav graph (with non-nullable parameters).

Note: sorry for the spam but I am not able to edit my own comment.

ap...@google.com <ap...@google.com> #6Apr 5, 2021 11:34PM

This has been fixed and will be available in navigation 2.6.0-alpha08

ap...@google.com <ap...@google.com> #7Apr 7, 2021 05:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6b358154b794a0456b089ac8e548bfb830dd6c22
Author: Clara Fok <clarafok@google.com>
Date: Tue Mar 14 17:56:12 2023

Fix missing non-nullable arg when rebuilding hierarchy

When navigating with NavDirections, args is populated with an empty bundle. This causes issue when we rebuild parent hierarchy while adding a new entry to NavBackStack. If the Entry being rebuilt contains a non-nullalbe arg, i.e. Long, this empty bundle will cause an exception.

Test: ./gradlew navigation:navigation-runtime:cC
Bug: 249988437
Change-Id: I5c8ce739ad9a3428c8a8de13eae391bfff0db5df

M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2488855

jb...@google.com <jb...@google.com> #8Apr 7, 2021 05:40PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-runtime:2.6.0-alpha08

ap...@google.com <ap...@google.com> #9Apr 13, 2021 12:29AM

Project: platform/frameworks/support
Branch: androidx-main

commit 2a78a49583442afe6872e72d1b822b0f4244ddb7
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Apr 12 10:57:31 2021

Making truth, testing, and utils depend on base modules

Since all of navigation is now in kotlin and the -ktx modules are empty,
we should switch all modules to depend directly on the base module.

Also changed all the modules that use internal-testutils-navigation to
exclude navigation-common base module instead of the ktx.

RelNote: "The Navigation Testing and Navigation Test modules now depend
on the base Navigation modules instead of the empty -ktx modules."
Test: all tests pass
Bug: 184292145

Change-Id: I1b5f5cdb63ae1912cbd9ffb0dbbdc44664fd179a

M hilt/hilt-navigation-fragment/build.gradle
M navigation/integration-tests/testapp/build.gradle
M navigation/navigation-compose/build.gradle
M navigation/navigation-fragment/build.gradle
M navigation/navigation-runtime-truth/build.gradle
M navigation/navigation-testing/build.gradle
M navigation/navigation-ui/build.gradle
M testutils/testutils-navigation/build.gradle

https://android-review.googlesource.com/1673529