AlertDialog does not leave enough space for the buttons [184355105]

Fixed

Bug

Status Update

No update yet.

Description

sp...@gmail.com

created issue #1

Apr 3, 2021 01:00PM

I have an AlertDialog containing a LazyVerticalGrid, a confirmButton, and a dismissButton. When the grid gets tall enough to that it needs to scroll, the buttons are left without enough space to display and they'red clipped at the bottom of the dialog. I'm not sure how clear that description is, so I attached a screenshot.

Screenshot_1617454666.png

77 KB

View

Download

Comments

pa...@google.com <pa...@google.com> #2Apr 6, 2021 01:38PM

Fixed in https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3031649

Added itemColors function to NavigationSuiteDefaults so developers can do like so:

val itemColors = NavigationSuiteDefaults.itemColors(/* change only what they want to change*/)

NavigationSuiteScaffold(
  navigationSuiteItems = {
    item(
      ... 
      colors = itemColors
    )
  },
){...}

pa...@google.com <pa...@google.com> #3Apr 21, 2021 12:06PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3-adaptive-navigation-suite:1.0.0-alpha06
androidx.compose.material3:material3-adaptive-navigation-suite-android:1.0.0-alpha06
androidx.compose.material3:material3-adaptive-navigation-suite-desktop:1.0.0-alpha06

po...@google.com <po...@google.com> Apr 22, 2021 03:57PM

Reassigned to po...@google.com.

pa...@google.com <pa...@google.com> #4Apr 22, 2021 03:58PM

اريدها بسعر اقل

ap...@google.com <ap...@google.com> #5Apr 23, 2021 10:25AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a153977dfc2a43aadb38a1e5a1a151336f8c2360
Author: Mihai Popa <popam@google.com>
Date: Thu Apr 22 18:34:55 2021

Row/Column wrap content if no weight+fill child

Relnote: "Row & Column children with weight(fill = false) are no longer making the parent fill the entire available main axis space."
Fixes: 186012444
Fixes: 184355105
Test: RowColumnTest + manual testing for AlertDialog
Change-Id: Ied94da682f4cf6ead5b91e06ba08904c1a349b9f

M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/RowColumnTest.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/RowColumnImpl.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt

https://android-review.googlesource.com/1684872

Issue 184355105