Fixed
Status Update
No update yet.
Comments
pa...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
pa...@google.com
Can you please post here a repro?
po...@google.com
pa...@google.com
Discussed with Mihai. The issue is that Column that is used in the Dialog can't be configured to reserve space for buttons. Over to Mihai to look into this and see what we can do with Column to support it.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit a153977dfc2a43aadb38a1e5a1a151336f8c2360
Author: Mihai Popa <popam@google.com>
Date: Thu Apr 22 18:34:55 2021
Row/Column wrap content if no weight+fill child
Relnote: "Row & Column children with weight(fill = false) are no longer making the parent fill the entire available main axis space."
Fixes: 186012444
Fixes: 184355105
Test: RowColumnTest + manual testing for AlertDialog
Change-Id: Ied94da682f4cf6ead5b91e06ba08904c1a349b9f
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/RowColumnTest.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/RowColumnImpl.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
https://android-review.googlesource.com/1684872
Branch: androidx-main
commit a153977dfc2a43aadb38a1e5a1a151336f8c2360
Author: Mihai Popa <popam@google.com>
Date: Thu Apr 22 18:34:55 2021
Row/Column wrap content if no weight+fill child
Relnote: "Row & Column children with weight(fill = false) are no longer making the parent fill the entire available main axis space."
Fixes: 186012444
Fixes: 184355105
Test: RowColumnTest + manual testing for AlertDialog
Change-Id: Ied94da682f4cf6ead5b91e06ba08904c1a349b9f
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/RowColumnTest.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/RowColumnImpl.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
Description
I have an AlertDialog containing a LazyVerticalGrid, a confirmButton, and a dismissButton. When the grid gets tall enough to that it needs to scroll, the buttons are left without enough space to display and they'red clipped at the bottom of the dialog. I'm not sure how clear that description is, so I attached a screenshot.