Inconsistent application of attributes to annotated string within a Text [184760917]

Verified

Bug

Status Update

No update yet.

Description

ex...@gmail.com

created issue #1

Apr 7, 2021 07:54PM

AS Canary 13, beta04

There are some inconsistencies when Text parameters are combined with an AnnotatedString input. In the example below (see screenshot as well) the fontSize, textDecoration, color, and letterSpacing parameters of Text are applied to the whole annotated text, but the fontStyle and fontFamily parameters are not. I expected "World" to display as bold, italic and monospace.

Note also how textDecoration = TextDecoration.LineThrough from the annotated string and TextDecoration.Underline on the Text combine, which seems reasonable, until you consider attributes like color, which override: color specified in annotated text overrides the parameter color in Text for the annotated portion, as expected (not shown in example).

@Composable
fun AnnotatedStringWithinText() {
    val text = buildAnnotatedString {
        append("Hello ")
        withStyle(style = SpanStyle(
            fontWeight = FontWeight.Bold,
            textDecoration = TextDecoration.LineThrough
        )) {
            append("World")
        }
    }
    Text(text = text,
        fontSize = 30.sp, // Applies to "Hello World"
        textDecoration = TextDecoration.Underline, // Applies to "Hello World"
        color = Color.Blue, // Applies to "Hello World"
        letterSpacing = 20.sp, // Applies to "Hello World"
        fontStyle = FontStyle.Italic, // Applies only to "Hello"
        fontFamily = FontFamily.Monospace // Applies only to "Hello"
    )
}

AnnotatedStringWithinText.png

6.8 KB

View

Download

Comments

si...@google.com <si...@google.com> #2Apr 7, 2021 09:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

si...@google.com <si...@google.com> Apr 7, 2021 09:09PM

Assigned to an...@google.com.

si...@google.com <si...@google.com> Apr 7, 2021 09:23PM

Reassigned to ha...@google.com.

ha...@google.com <ha...@google.com> Apr 12, 2021 06:22PM

Accepted by ha...@google.com.

ap...@google.com <ap...@google.com> #3Apr 14, 2021 03:13AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ha...@google.com <ha...@google.com> May 5, 2021 06:53PM

Marked as fixed.

ap...@google.com <ap...@google.com> #4May 5, 2021 06:53PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ex...@gmail.com <ex...@gmail.com> #5May 7, 2021 02:14PM

I tried this on beta06 (assuming that's where the fix went) and fontStyle and fontFamily now apply as expected. However, I still get underlining AND linethrough on "World". I wanted to confirm that it is your intention to combine them, based on the comments above.

Playing with the example further:

Changing the Text to TextDecoration.None results in no decoration on "Hello" but a linethrough on "World" (seems reasonable -- annotated overrides Text)
Changing the annotated "World" to TextDecoration.None and the Text to TextDecoration.LineThrough (as suggested in the comments above) results in a linethrough on "Hello World" (seems inconsistent -- shouldn't "World" have no decoration?)

(And sometimes, oddly, I have to uninstall the test app manually in the emulator before the new code will take effect.)

ha...@google.com <ha...@google.com> #6May 7, 2021 07:38PM

Hi, thanks for your report! The fixing CL for TextDeocration and LineThrough was just merged recently. And it's probably not included in the beta-06, can you please check it again in next release?

ex...@gmail.com <ex...@gmail.com> #7May 7, 2021 11:41PM

OK, I will. (I had assumed that since the result had changed from the last time I ran the testcase that this fix was applied, but maybe some other change was responsible.)

ex...@gmail.com <ex...@gmail.com> #8May 20, 2021 01:39PM

The fix works as expected in beta07.

(I still occasionally have to uninstall the test app manually in the emulator before the new code will take effect. I'm sure this is an AS issue but it seems to hit mostly (only?) when I've been running this test.)

ha...@google.com <ha...@google.com> #9May 20, 2021 03:09PM

Verified by ha...@google.com.

Thanks for the confirmation! I'll mark it as verified for now. :)