windowSoftInputMode = adjustPan issue with decorationBox and BasicTextField [184760918]

Fixed

Bug

Status Update

No update yet.

Description

ti...@hotmail.com

created issue #1

Apr 7, 2021 08:50PM

Jetpack Compose release version: 1.0.0-beta01
Android Studio Build: Android Studio Arctic Fox 2020.3.1 Canary 8

If the software keyboard comes into view, decorationBox of BasicTextField gets ignored. The keyboard appears --> the content scrolls up, but only until the TextFields input area. It does not observe the extra padding provided by the decorationBox.


decorationBox = { innerTextField ->

                Surface(
                    modifier = Modifier.padding(horizontal = 10.dp, vertical = 6.dp),
                    color = MaterialTheme.colors.primary
                ) {
                    Row(
                        horizontalArrangement = Arrangement.SpaceBetween,
                        verticalAlignment = Alignment.CenterVertically
                    ) {
                        val fontScale =  Settings.System.FONT_SCALE


                        Column(modifier = Modifier.widthIn(min= 10.dp, max = resizeTextField(newString, size = sizeInDP))) {
                            innerTextField()
                        }
                        Spacer(modifier = Modifier.width(5.dp))
                        Text(
                            unitShortcut,
                            color = MaterialTheme.colors.onBackground,
                            style = MaterialTheme.typography.h2,
                            fontWeight = FontWeight.Normal,
                            softWrap = true,
                            maxLines = 1,
                        )
                    }

                }


            }

Screenshot_1617826983.png

109 KB

View

Download

Comments

se...@google.com <se...@google.com> Apr 7, 2021 08:51PM

Assigned to an...@google.com.

si...@google.com <si...@google.com> #2Apr 7, 2021 09:11PM

Reassigned to so...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

so...@google.com <so...@google.com> #3Apr 8, 2021 11:25AM

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

si...@google.com <si...@google.com> #4Apr 8, 2021 11:43PM

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

si...@google.com <si...@google.com> #5Apr 20, 2021 07:40AM

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

ni...@google.com <ni...@google.com> #6Jun 3, 2021 01:03AM

Bugjuggler: wait until 2022-03-23

so...@google.com <so...@google.com> #7Oct 18, 2021 03:37PM

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.

so...@google.com <so...@google.com> #8Feb 10, 2022 06:53PM

Reassigned to kl...@google.com.

Is there a replacement or should we just abandon TextClassifier for android older than API Level 26 ?

kl...@google.com <kl...@google.com> #9Apr 15, 2022 09:18PM

Accepted by kl...@google.com.

Abandon. The owning team had no plans to release a replacement library.

ap...@google.com <ap...@google.com> #10Apr 19, 2022 03:26PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 04501ae82a6f8349c5a4037080bb2b93c7fddefe
Author: Zach Klippenstein <klippenstein@google.com>
Date: Fri Apr 15 15:26:57 2022

Ignore bringIntoView requests that are already satisfied by an in-progress request.

If a new bringIntoView call happens before the previous one is finished,
then if the new one requests a rectangle that will already be in
view after the old request is satisfied, the new request is ignored.

Bug:

b/216790855

Fixes:

b/184760918

Test: New tests for BringIntoViewResponder and text field.
Test: ./gradlew :compose:f:f:cDAT
Relnote: "Concurrent `BringIntoViewRequester.bringIntoView` calls for
rectangles that are completely overlapping will now only honor the
larger rectangle's request."

Change-Id: I34be70f23527e4fea694fd5266bbc127cc1d1b0b

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldFocusTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/relocation/BringIntoViewRequester.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextFieldsInScrollableDemo.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponderTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponder.kt

https://android-review.googlesource.com/2065910