Status Update
Comments
so...@google.com <so...@google.com>
so...@google.com <so...@google.com>
pa...@google.com <pa...@google.com> #2
ae...@google.com <ae...@google.com> #3
Thanks for the report!
pa...@google.com <pa...@google.com> #4
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified)
, or create a custom Typography
entirely.
ae...@google.com <ae...@google.com> #5
so...@google.com <so...@google.com> #6
In my case, I have multiple font sizes in the same Text
(using SpanStyle
in AnnotatedString
). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
so...@google.com <so...@google.com>
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit e8f93a08af0f03ccb5e86b0bd157935a609737e8
Author: Filip Pavlis <pavlis@google.com>
Date: Thu Apr 29 16:31:33 2021
Use list for content description and text.
This CL changes semantics properties of contentDescrtiption and text to
be lists instead of single values. This avoids the need having to join
them via comma during merging which erases useful information.
Bug: 184825850
Test: Added
Relnote: "ContentDescription and Text semantics properties are no longer
single values but lists. This enables to merge them as they are instead
of concatenations. Also provided better testing APIs to utilize these
changes"
Change-Id: Ica6bf4236d05b97357c18fb306a6305877a349f7
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ImageTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/IconTest.kt
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/ParametersTest.kt
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/LayoutInspectorTreeTest.kt
M compose/ui/ui-test/api/1.0.0-beta08.txt
M compose/ui/ui-test/api/current.ignore
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_1.0.0-beta08.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_1.0.0-beta08.txt
M compose/ui/ui-test/api/restricted_current.ignore
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/AssertsTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/ErrorMessagesTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/FindersTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/PrintToStringTest.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/assertions/AssertContentDescription.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/assertions/AssertText.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
M compose/ui/ui/api/1.0.0-beta08.txt
M compose/ui/ui/api/current.ignore
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta08.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta08.txt
M compose/ui/ui/api/restricted_current.ignore
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/semantics/SemanticsTests.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt
pa...@google.com <pa...@google.com> #9
This was now fixed by using lists for content description & text. Test API's are now a bit smarter as they can use the lists.
This changes is breaking but was pre-approved in
I did several experiments locally and also waited for our CI to trigger any alerts afterwards and concluded that this change had no measurable impact on our benchmarks.
so...@google.com <so...@google.com> #10
Oops, I kept this ticket to track a11y work that we're currently doing. I'll create a new one :)
pa...@google.com <pa...@google.com> #11
Ops, sorry about that.
Description
In changed changing testing behavior. For example this test no longer passes:
beta04
semantics mergingComposable
With the changes in
beta04
theIcon
s content description is no longer merged to the parentFloatingActionButton
so it does not appear in the merged semantics tree.