Semantics merging [184825850]

Fixed

Bug

Status Update

No update yet.

Description

ni...@google.com

created issue #1

Apr 8, 2021 11:43AM

In beta04 semantics merging changed changing testing behavior. For example this test no longer passes:

https://github.com/android/compose-samples/blob/main/Owl/app/src/androidTest/java/com/example/owl/ui/NavigationTest.kt#L71

Composable

FloatingActionButton(
    onClick = onboardingComplete,
    modifier = Modifier
        .navigationBarsPadding()
) {
    Icon(
        imageVector = Icons.Rounded.Explore,
        contentDescription = stringResource(R.string.label_continue_to_courses)
    )
}

With the changes in beta04 the Icons content description is no longer merged to the parent FloatingActionButton so it does not appear in the merged semantics tree.

Comments

so...@google.com <so...@google.com> Apr 8, 2021 11:44AM

Reassigned to so...@google.com.

so...@google.com <so...@google.com> Apr 8, 2021 01:41PM

Reassigned to pa...@google.com.

pa...@google.com <pa...@google.com> #2Apr 8, 2021 03:41PM

Reassigned to ae...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ae...@google.com <ae...@google.com> #3Apr 15, 2021 05:42PM

Thanks for the report!

pa...@google.com <pa...@google.com> #4Apr 15, 2021 05:48PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ae...@google.com <ae...@google.com> #5Apr 15, 2021 07:18PM

deleted

so...@google.com <so...@google.com> #6Apr 15, 2021 07:30PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

ae...@google.com <ae...@google.com> #7Apr 16, 2021 01:29AM

OK, here is the doc: https://docs.google.com/document/d/1xzpdqIif7MOn6L80UDpzSYa8dBk8XgRlN8bdIYj6Emg/edit#heading=h.z6aofiqcy66y

so...@google.com <so...@google.com> May 6, 2021 02:06PM

Reassigned to so...@google.com.

ap...@google.com <ap...@google.com> #8May 20, 2021 03:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit e8f93a08af0f03ccb5e86b0bd157935a609737e8
Author: Filip Pavlis <pavlis@google.com>
Date: Thu Apr 29 16:31:33 2021

Use list for content description and text.

This CL changes semantics properties of contentDescrtiption and text to
be lists instead of single values. This avoids the need having to join
them via comma during merging which erases useful information.

Bug: 184825850
Test: Added
Relnote: "ContentDescription and Text semantics properties are no longer
single values but lists. This enables to merge them as they are instead
of concatenations. Also provided better testing APIs to utilize these
changes"

Change-Id: Ica6bf4236d05b97357c18fb306a6305877a349f7

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ImageTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/IconTest.kt
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/ParametersTest.kt
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/LayoutInspectorTreeTest.kt
M compose/ui/ui-test/api/1.0.0-beta08.txt
M compose/ui/ui-test/api/current.ignore
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_1.0.0-beta08.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_1.0.0-beta08.txt
M compose/ui/ui-test/api/restricted_current.ignore
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/AssertsTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/ErrorMessagesTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/FindersTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/PrintToStringTest.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/assertions/AssertContentDescription.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/assertions/AssertText.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
M compose/ui/ui/api/1.0.0-beta08.txt
M compose/ui/ui/api/current.ignore
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta08.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta08.txt
M compose/ui/ui/api/restricted_current.ignore
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/semantics/SemanticsTests.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/1690808

pa...@google.com <pa...@google.com> #9May 24, 2021 02:54PM

Marked as fixed, reassigned to pa...@google.com.

This was now fixed by using lists for content description & text. Test API's are now a bit smarter as they can use the lists.

This changes is breaking but was pre-approved in b/187317059 with the condition that we keep an eye on performance.

I did several experiments locally and also waited for our CI to trigger any alerts afterwards and concluded that this change had no measurable impact on our benchmarks.

so...@google.com <so...@google.com> #10May 24, 2021 03:37PM

Oops, I kept this ticket to track a11y work that we're currently doing. I'll create a new one :)

pa...@google.com <pa...@google.com> #11May 24, 2021 03:46PM

Ops, sorry about that.